Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retype v3.4 has an issue with "expanded" #623

Closed
patricklafrance opened this issue Sep 9, 2023 · 2 comments
Closed

Retype v3.4 has an issue with "expanded" #623

patricklafrance opened this issue Sep 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@patricklafrance
Copy link

patricklafrance commented Sep 9, 2023

Hello!

I have a website using Retype v3.3 (web-configs) and another one using Retype 3.4 (@squide). Both websites have every folder configured with expanded: true.

With v3.3 it works as expected:

retype_3 3

But with v3.4 they keep closing:

retype_3 4

Thank you,

Patrick

@geoffreymcgill
Copy link
Collaborator

Confirmed, this is a bug introduced with v3.4.0. We are going to fix immediately and make a v3.4.1 patch release, hopefully late tomorrow.

Sorry about this.

Thanks for reporting.

@patricklafrance patricklafrance changed the title Retype v3.4 have an issue with "expanded" Retype v3.4 has an issue with "expanded" Sep 9, 2023
@geoffreymcgill geoffreymcgill self-assigned this Sep 10, 2023
@geoffreymcgill geoffreymcgill added the bug Something isn't working label Sep 10, 2023
@geoffreymcgill geoffreymcgill added this to the v3.4.1 milestone Sep 10, 2023
@geoffreymcgill
Copy link
Collaborator

Retype v3.4.1 has been released and includes a fix for this bug.

This bug was mistakingly introduced when the related Tree nav expanded state not saving bug was fixed in v3.4.0. Resetting of the tree navigation was actually a "feature" we had built very early on in Retype, although because of bug that was not caught until v3.4.0, this "feature" was not actually working.

Things should be working better now. No changes are required in your project, other than upgrading to the latest Retype release.

@patricklafrance Thanks again for letting us know about this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants