Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nu Html Checker: Improve Html Quality #583

Closed
throwaway-d opened this issue Jul 7, 2023 · 7 comments
Closed

Nu Html Checker: Improve Html Quality #583

throwaway-d opened this issue Jul 7, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@throwaway-d
Copy link

throwaway-d commented Jul 7, 2023

https://codeberg.org/rimgo/docs/issues/3
I've put Rimgo website through a website checker called Nu Html Checker for some clean HTML suggestions to improve Rimgo website. I contacted the owner of Rimgo website about those suggestions. But the owner told me that all HTML is written by Retype, the owner didn't have any control over generated HTML.

Retype generates all the HTML, I can't do anything about this.

So I think I should report the suggestions to Retype instead, right?

Here are the HTML suggestions: https://validator.w3.org/nu/?showsource=yes&showoutline=yes&showimagereport=yes&doc=https%3A%2F%2Frimgo.codeberg.page%2Fdocs%2F

@geoffreymcgill geoffreymcgill self-assigned this Jul 7, 2023
@geoffreymcgill geoffreymcgill added the enhancement New feature or request label Jul 7, 2023
@geoffreymcgill
Copy link
Collaborator

geoffreymcgill commented Jul 7, 2023

Thanks for the report.

The type="text/javascript" attribute has been removed from <script> tags in the upcoming Retype v3.1.0 release.

Looks like we can easily remove the closing / forward-slash on the <meta> and <input> tags. I guess we're just more accustomed to writing XHTML instead of HTML5.

Removing the v-cloak directive is going to cause an issue with the VueJS component rendering, but I'll see if there is an alternative technique.

I'll take a look at the other items in the report and see where we can improve the HTML generation.

@throwaway-d
Copy link
Author

By the way, I wanted to ask why my another issue about accessibility got deleted.

@geoffreymcgill
Copy link
Collaborator

By the way, I wanted to ask why my another issue about accessibility got deleted.

The other post looked like a duplicate. Sorry about that.

Here's the content if you want to recreate.

Subject: PageSpeed Insights: Accessibility suggestions

https://codeberg.org/rimgo/docs/issues/7
I've put Rimgo website through a website checker called PageSpeed Insights for some performance and accessibility suggestions to improve Rimgo website. I contacted the owner of Rimgo website about those suggestions. But the owner told me that all HTML is written by Retype, the owner didn't have any control over generated HTML.

Retype generates the website, can't do anything about those suggestions. Those speed suggestions need to be added to Codeberg Pages, [Codeberg/pages-server#223](https://codeberg.org/Codeberg/pages-server/issues/223)

So I think I should report the suggestions to Retype instead, right?

Here are the accessibility suggestions: https://pagespeed.web.dev/analysis/https-rimgo-codeberg-page-docs/ojicpsz30p?form_factor=mobile

@throwaway-d
Copy link
Author

throwaway-d commented Jul 7, 2023

The other post looked like a duplicate. Sorry about that.
Here's the content if you want to recreate.

No problem! Thank you for explaining and helping me to recreate! :D
Unlike some other repos which people had closed my issues without explaining why they were closed; you are really supportive and explanative!

@geoffreymcgill
Copy link
Collaborator

geoffreymcgill commented Jul 7, 2023

Unlike some other repos which people had closed my issues without explaining why they was closed; you are really supportive and explanative!

Your two posts used similar language and were submitted near the same time. I quickly scanned the two and assumed they were duplicated. Plus your username is throwaway-d, so based on that, I really didn't want to invest much time. Because of your username, I can easily see why other repo owners would close/delete your issues without explaining why.

@geoffreymcgill
Copy link
Collaborator

We completed some clean up of the HTML syntax. The enhancements will be included in the upcoming Retype v3.1 release.

The v-cloak and v-pre are Vue directives and removed once the Vue parsing is complete. The reports are generated from the raw HTML and not post-Vue processing. The <template #title> and <template #sidebar-footer> items are VueJS related too.

There is still work to be done with the HTML syntax, especially related to Accessibility, but we will continue to make improvements in future releases.

Hope this helps.

@geoffreymcgill geoffreymcgill added this to the v3.1 milestone Jul 7, 2023
@throwaway-d
Copy link
Author

Thank you for your work and pointing out my username's problem! :)
I might change my username soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants