Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dash docset URL is incorrect #1188

Closed
sindresorhus opened this issue May 7, 2020 · 3 comments
Closed

The Dash docset URL is incorrect #1188

sindresorhus opened this issue May 7, 2020 · 3 comments
Labels

Comments

@sindresorhus
Copy link

sindresorhus commented May 7, 2020

Jazzy config: https://github.com/sindresorhus/KeyboardShortcuts/blob/a1550ae2c7fc96e07648cc045855eb89ab621b87/.jazzy.yml

I think it's because I upload the docs to a sub-path: https://sindresorhus.com/KeyboardShortcuts/ (not visible as I'm hiding it for now with JavaScript)

The Dash feed URL ends up being dash-feed://https%3A%2F%2Fsindresorhus%2Ecom%2Fdocsets%2FKeyboardShortcuts%2Exml, where the URL decoded is https://sindresorhus.com/docsets/KeyboardShortcuts.xml, while it should have been https://sindresorhus.com/KeyboardShortcuts/docsets/KeyboardShortcuts.xml. The URL in the XML is also incorrect.

I tried setting dash_url: https://sindresorhus.com/KeyboardShortcuts/docsets/KeyboardShortcuts.xml, but that didn't help.

@johnfairh johnfairh added the bug label May 7, 2020
@johnfairh
Copy link
Collaborator

johnfairh commented May 7, 2020

Thanks - looks like this has never worked when there's a path component in the URL (Yikes).

edit: Actually it's not that bad: dash_url works fine, maybe check again? And your root_url works OK if you stick a / on the end, ie. https://sindresorhus.com/KeyboardShortcuts/.

@sindresorhus
Copy link
Author

Thanks for looking into this. I'll just wait until this is properly fixed. The Dash link is not important for me and my current workaround works fine for now.

@johnfairh
Copy link
Collaborator

Fixed in master via #1197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants