-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to skip byte compilation of package's .el files #357
Comments
I don't object to adding such an option, but only if there's a use case for it. What problem would this solve? |
Thanks for your reply! In my eyes this option
I tried my luck with the following implementation, inspired by (setq straight--build-keywords
'(:local-repo :files :no-autoloads :no-byte-compilation))
(defcustom straight-disable-byte-compilation nil
:type 'boolean)
(cl-defun straight--byte-compile-package (recipe)
"Byte-compile files for the symlinked package specified by RECIPE.
RECIPE should be a straight.el-style plist. Note that this
function only modifies the build folder, not the original
repository. TEST: has `:no-byte-compilation' added."
(when (straight--plist-get recipe :no-byte-compilation straight-disable-byte-compilation)
(cl-return-from straight--byte-compile-package))
..... ) And it appears to work, even though I should say that I am still an emacs-lisp noob. Thank you for your time and consideration. |
Thanks for your detailed analysis! I very much appreciate it :) As for sharing As for dealing with macro problems, I feel your pain. The UX for byte-compilation is very bad. However, in my experience, there is always a way of working around the problem without disabling byte-compilation, even if it takes a while to figure out. And this is desirable: after all, byte-compilation improves startup time. I don't personally byte-compile my init-file (yet), so I haven't really investigated how However, if you are still inexperienced with Emacs Lisp, this might not be worth your time. I have several years of experience and I still find it extremely confusing. In any case, allowing one to disable byte-compilation sounds like a perfectly reasonable idea. Since it is a trivial change, I implemented it in the above commit. |
Thanks a lot for implementing my proposal! Keep up the great work with |
Hey @raxod502
Would it be possible to have an option in
straight.el
which skips byte compilation and have only the.el
files symlinked into the build folder?So one could write (just an example):
The text was updated successfully, but these errors were encountered: