Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should BACKGROUND_EVICTION_INTERVAL be of type Option<Duration> #180

Closed
duyleekun opened this issue Oct 5, 2022 · 1 comment
Closed
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: bug A general bug
Milestone

Comments

@duyleekun
Copy link

duyleekun commented Oct 5, 2022

public static final Option<Integer> BACKGROUND_EVICTION_INTERVAL = Option.valueOf("backgroundEvictionInterval");

I'm unable to set BACKGROUND_EVICTION_INTERVAL via ConnectionFactoryOptions.builder().option(PoolingConnectionFactoryProvider.BACKGROUND_EVICTION_INTERVAL,XXXX)

Seem like XXXX can only be Integer and internally, it requires it to be either String or Duration. Am I missing something?

@mp911de
Copy link
Member

mp911de commented Oct 5, 2022

Good catch, do you want to submit a pull request to fix that issue?

@mp911de mp911de added type: bug A general bug status: ideal-for-contribution An issue that a contributor can help us with labels Oct 5, 2022
@mp911de mp911de added this to the 1.0.0.RELEASE milestone Nov 8, 2022
@mp911de mp911de closed this as completed in d7cd349 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants