Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix reputation decrease #2087

Closed
7 tasks
kamilsa opened this issue May 13, 2024 · 0 comments · Fixed by #2102
Closed
7 tasks

[Bug]: Fix reputation decrease #2087

kamilsa opened this issue May 13, 2024 · 0 comments · Fixed by #2102
Assignees
Labels
bug Something isn't working

Comments

@kamilsa
Copy link
Contributor

kamilsa commented May 13, 2024

Bug Summary

Our reputation is decreased too much by other peers

Bug Description

It is observed in Westend network, that KAGOME validator's reputation is decreased too much comparing to other validators.

Here is the breakdown into smaller tasks with corresponding number of appearances of each problem in provided log file below:

  • Fix Unexpected Statement, invalid sender (633 appearances)
  • Fix Unexpected Statement, missing knowledge for relay parent (112 appearances)
  • Fix Peer sent an out-of-view assignment or approval (372 appearances)
  • Fix Not interested in that parent hash (38 appearances)
  • Fix Unexpected Manifest, Peer Unknown (4374 appearances)
  • Fix The vote was valid but too far in the future (182 appearances)
  • Zombienet test ensuring that our reputation is not decreasing #2088

Steps to Reproduce

Run KAGOME validator

Effects of the Bug

Too many reputation decrease log messages from other validators

Expected Behavior

For comparison, another validator's reputation was decreased only 15 times for the same period

Image

System Information

Docker container: kamilsa/kagome:320254a2 running in validator mode

Additional Context

Logs with reputation decrease of our KAGOME node (received from another westend validator, running on Polkadot-SDK)
reduce-reputation.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants