Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report title should reflect in report tab name #412

Closed
gnikonorov opened this issue Dec 12, 2020 · 1 comment · Fixed by #420
Closed

Report title should reflect in report tab name #412

gnikonorov opened this issue Dec 12, 2020 · 1 comment · Fixed by #420
Assignees
@gnikonorov
Labels
bug This issue/PR relates to a bug.

Comments

@gnikonorov
Copy link
Member

gnikonorov commented Dec 12, 2020 •
edited
Loading

Currently the tab of the report always has its text set to "Test Report" regardless of what the actual title of the report is. I propose to instead always have it set to the report title.

If there are no objections @ssbarnea / @BeyondEvil I'll go ahead and make a PR
@gnikonorov gnikonorov added the bug This issue/PR relates to a bug. label Dec 12, 2020
@gnikonorov gnikonorov self-assigned this Dec 12, 2020
@BeyondEvil
Copy link
Contributor

No objections from me @gnikonorov and I can't see a reason that @ssbarnea would object either, I think it's safe for you to go ahead and make a PR for it. 😊

@gnikonorov gnikonorov mentioned this issue Dec 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikonorov gnikonorov

Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the report tab title reflect the report name gnikonorov/pytest-html
2 participants
@gnikonorov @BeyondEvil