Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extras from reruns are attached to final test #374

Closed
VladimirPodolian opened this issue Nov 20, 2020 · 9 comments · Fixed by #387
Closed

Extras from reruns are attached to final test #374

VladimirPodolian opened this issue Nov 20, 2020 · 9 comments · Fixed by #387
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@VladimirPodolian
Copy link

VladimirPodolian commented Nov 20, 2020

Deps:

  • pytest==6.1.2
  • pytest-rerunfailures==9.1.1
  • pytest-selenium==2.0.1
  • pytest-html==2.1.1/3.0.0

After updating pytest-html to 3.0.0 version in project requirements I got unexpected extras from test reruns in html report. Actually all extras from test reruns (logs/links/duration/screenshots) also applied to final test with failed/passed result.

Ver 3.0.0

SM

Ver 2.1.1

SM1

Ver 2.1.1 had a bug with missing screenshots, but other data correct. So my opinion that something was broken since ver 3.0.0

@VladimirPodolian VladimirPodolian changed the title Extras from reruns applied to final test Extras from reruns are attached to final test Nov 20, 2020
@gnikonorov gnikonorov added the bug This issue/PR relates to a bug. label Nov 28, 2020
@gnikonorov gnikonorov self-assigned this Nov 28, 2020
@gnikonorov
Copy link
Member

Hey @VladimirPodolyan thanks for raising this issue! Let me try and make a reproducer on my end.

@gnikonorov
Copy link
Member

For now, I'm thinking that every rerun should be its own entry in the table

@gnikonorov
Copy link
Member

Screen Shot 2020-11-28 at 10 38 31 AM

It looks like we already have one entry per rerun, but the data is populating incorrectly

@gnikonorov
Copy link
Member

I should have a PR up for this today or tomorrow, @VladimirPodolyan. Thank you for reporting this

@VladimirPodolian
Copy link
Author

@gnikonorov Thank for respond and fixing the issue!

@gnikonorov
Copy link
Member

@gnikonorov Thank for respond and fixing the issue!

Of course @VladimirPodolyan ! I'll merge this in EOD today so it'll be available off of head and I'm planning to release to PyPI by the end of 12/2.

@gnikonorov
Copy link
Member

Hi @VladimirPodolyan you can get this functionality by installing the latest version of pytest-html from PyPI

@VladimirPodolian
Copy link
Author

@gnikonorov The report looks fine now. Thanks for the poke!

@gnikonorov
Copy link
Member

@gnikonorov The report looks fine now. Thanks for the poke!

Of course! Glad to hear it works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants