Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: preactjs/preact-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 84e5ed6625e92a7749a08313b0d6cd79a1beb1ca
Choose a base ref
..
head repository: preactjs/preact-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 87325923da97c4aee345ad00570dc1929ee7c68b
Choose a head ref
Showing with 21 additions and 14 deletions.
  1. +21 −14 packages/cli/tests/config.test.js
35 changes: 21 additions & 14 deletions packages/cli/tests/config.test.js
Original file line number Diff line number Diff line change
@@ -10,10 +10,7 @@ const prerenderUrlFiles = [
'function-returning-stringified-array.js',
];

const preactConfigFiles = [
'function.js',
'object.js'
];
const preactConfigFiles = ['function.js', 'object.js'];

describe('config files', () => {
describe('prerender-urls', () => {
@@ -25,7 +22,9 @@ describe('config files', () => {
await build(dir);

expect(logSpy).not.toHaveBeenCalledWith(
expect.stringContaining('Failed to load prerenderUrls file, using default!')
expect.stringContaining(
'Failed to load prerenderUrls file, using default!'
)
);
});

@@ -36,25 +35,31 @@ describe('config files', () => {

const logSpy = jest.spyOn(process.stdout, 'write');

await build(dir, { prerenderUrls: `prerender/${moduleFormat}/${dataFormat}` });
await build(dir, {
prerenderUrls: `prerender/${moduleFormat}/${dataFormat}`,
});

expect(logSpy).not.toHaveBeenCalledWith(
expect.stringContaining('Failed to load prerenderUrls file, using default!')
expect.stringContaining(
'Failed to load prerenderUrls file, using default!'
)
);
});
});
});

formats.forEach(moduleFormat => {
it(`should fail to load malformed prerender-urls data in ${moduleFormat}`, async () => {
let dir = await subject('multiple-config-files');

const logSpy = jest.spyOn(process.stdout, 'write');

await build(dir, { prerenderUrls: `prerender/${moduleFormat}/returns-bad-json.js` });
await build(dir, {
prerenderUrls: `prerender/${moduleFormat}/returns-bad-json.js`,
});

expect(logSpy).toHaveBeenCalledWith(
expect.stringContaining('Failed to load prerenderUrls file, using default!')
expect.stringContaining(
'Failed to load prerenderUrls file, using default!'
)
);
});
});
@@ -75,9 +80,11 @@ describe('config files', () => {
it(`should fail to load malformed config data in ${moduleFormat}`, async () => {
let dir = await subject('multiple-config-files');

await expect(build(dir, { config: `preactConfig/${moduleFormat}/returns-bad-config.js` }))
.rejects
.toThrow('Failed to load preact-cli config!');
await expect(
build(dir, {
config: `preactConfig/${moduleFormat}/returns-bad-config.js`,
})
).rejects.toThrow('Failed to load preact-cli config!');
});
});
});