Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't junit dependency in POM have test scope? #14

Open
vvdleun opened this issue Nov 4, 2017 · 0 comments
Open

Shouldn't junit dependency in POM have test scope? #14

vvdleun opened this issue Nov 4, 2017 · 0 comments

Comments

@vvdleun
Copy link
Contributor

vvdleun commented Nov 4, 2017 •
edited
Loading

Hi,

I noticed my application bundles JUnit in its production JAR files. After looking around, I think it is caused by the POM file of mDNSJava:

<dependency>
    <groupId>junit</groupId>
    <artifactId>junit</artifactId>
    <version>4.12</version>
</dependency>

Shouldn't the "test" scope be specified here as well, or is there a reason for its compile scope?

Kind regards (and many thanks for your work on this awesome library!),
Vincent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vvdleun