Constructors don't have docstrings in generated documentation.

[SeanTAllen]

Moved from ponylang/ponylang-website#97

The Timers.create page
https://stdlib.ponylang.org/time-Timers/#create

Doe not include the docstring that appears in the 0.14 release

Create a timer handler with the specified number of slop bits. No slop bits
means trying for nanosecond resolution. 10 slop bits is approximately
microsecond resolution, 20 slop bits is approximately millisecond
resolution.

---

The docstring for the constructor is getting "lost" in traits.c at line 387:

  // Ignore docstring.
  if(ast_id(doc) == TK_STRING)
  {
    ast_set_name(doc, "");
    ast_setid(doc, TK_NONE);
  }

where it gets set to TK_NONE. What's very odd about this is why trait related code is being run on constructors for actors like Timers.

Additionally, does it make sense to remove the docstring from a trait? It does it the trait is overridden but would this also remove the docstring when not overridden? I'm not sure, that requires more exploration.

[SeanTAllen]

@Praetonus believes that the trait pass runs on every method whether there is a trait or not.

[SeanTAllen]

@Praetonus looking at the code says that the trait pass shouldnt be running here so we have a bug that needs to be fixed.

[EpicEric]

Is this still an issue? The docstring appears to have been correctly generated for the example.

[SeanTAllen]

It might on longer be an issue. Might have been accidentally fixed.

[EpicEric]

Closing on the assumption it was.

[mfelsche]

This was fixed with: #2586