Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corral reports error from primary compilation step #110

Closed
btab opened this issue May 12, 2020 · 10 comments
Closed

Corral reports error from primary compilation step #110

btab opened this issue May 12, 2020 · 10 comments

Comments

@btab
Copy link

btab commented May 12, 2020

On Windows (git bash).

ponyc -o build/release semver works fine and results in a 0 exit code

corral run -- ponyc -o build/release semver reports...

run: ponyc -o build/release semver
  exit: Exited(-1)
  out:
  err:
make: *** [build/release/semver.exe] Error -1
$ ponyc -v
0.35.0 [release]
Compiled with: LLVM 9.0.1 -- MSVC-19.25.28612.0-x64 1925

$ corral version
version: 0.3.4-e152293
@mfelsche
Copy link
Contributor

Can you move this issue to the corral repository, i am 100% sure this is a corral issue.

@SeanTAllen
Copy link
Member

I'm transferring this to corral.

@SeanTAllen SeanTAllen transferred this issue from ponylang/semver May 12, 2020
@mfelsche
Copy link
Contributor

@btab can you please report your PATH as being present in your git bash? Can you also report the path environment variable you can get from windows?

@mfelsche
Copy link
Contributor

also can you try the same on cmd or powershell?

@chalcolith
Copy link
Member

Seems to be fixed by ponylang/ponyc#3559

@btab
Copy link
Author

btab commented May 13, 2020

For completeness, @mfelsche...

From both Powershell and cmd I get the exact same result.

The PATH has a bunch of personal stuff on it so I won't share it but it's the same in cmd and git bash aside from the relevant path substitution. So, for example, in git bash...

/c/Users/andre/src/corral/build/release

...vs, the following in cmd...

C:\Users\andre\src\corral\build\release

@SeanTAllen
Copy link
Member

@btab Yeah, this is a bug recently introduced in the pony standard library that impacts only on Windows.

@btab
Copy link
Author

btab commented May 13, 2020

Indeed. I'll pull it down once the PR succeeds and verify the fix locally as well.

@SeanTAllen
Copy link
Member

Fix is now on ponyc master.

@btab
Copy link
Author

btab commented May 13, 2020

Latest corral + latest ponyc did fix the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants