Remove dependency on systemd-escape

[achilleas-k]

images/internal/common/helpers.go

Lines 40 to 51 in 0d62970

	// MountUnitNameFor returns the escaped name of the mount unit for a given
	// mountpoint by calling:
	//
	// systemd-escape --path --suffix=mount "mountpoint"
	func MountUnitNameFor(mountpoint string) (string, error) {
	cmd := exec.Command("systemd-escape", "--path", "--suffix=mount", mountpoint)
	stdout, err := cmd.Output()
	if err != nil {
	return "", fmt.Errorf("systemd-escape call failed: %s", ExecError(err))
	}
	return strings.TrimSpace(string(stdout)), nil
	}

We shouldn't depend on systemd-escape to generate manifests. We already have osbuild.pathEscape() which does most of it in plain Go code, but I think it's not 100%. It should be possible to make it a full port.

[achilleas-k]

See also: https://github.com/coreos/go-systemd/blob/main/unit/escape.go