Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transferred from Web repo] New designs of top navigation bar for samsung galaxy fold devices. #86

Open
2 of 3 tasks
prafulbbandre opened this issue Jul 19, 2023 · 9 comments
Assignees

Comments

@prafulbbandre
Copy link

prafulbbandre commented Jul 19, 2023

Platform
Oppia Web

Describe the request
According to the discussion on this issue oppia/oppia#18337 @ConorMack and @rfinch11 had advice to put the language selection to the hamburger menu but how should it look like in the hamburger menu is still not confirm so please provide a mock for it.
I might have miss it while searching if so Please corret me.

image
Currently the language selection is covering the oppia text and it is not looking good.

Note: this is also observed on Galaxy Fold dimensions: #121. It happens on multiple pages throughout the site, and the language and account buttons currently just disappear at like 355 px width (when they are supposed to just become smaller). This is due to the media query applied on the buttons:
image

The aim of this issue is to figure out how the navbar should work in a fully-responsive way across different devices.

DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.

  • UX Design approved
  • UX Writing approved
  • Product approved

For a design project to be completed, it needs approval from UXD, UXW and PM. Please tag the following reviewers when your project is ready (at least one reviewer for each of the 3 bullet points below):

@seanlip seanlip changed the title New designs of top navigation bar for samsung galaxy fold devices. [Tarnsferred from Web repo] New designs of top navigation bar for samsung galaxy fold devices. Jan 3, 2024
@kmuir1991
Copy link

@seanlip does this need a UXW? Seems to be UXD only.

@seanlip
Copy link
Member

seanlip commented Jan 5, 2024

Hi @kmuir1991, I agree it's mostly UXD. However, as a matter of policy, I suggest assigning a UXW to any issue that has a UXD, so that there is a point of contact for any UXW questions that come up. If the UXW is subsequently still unaffected, then UXW approval on the final designs should be trivial. (But one could imagine changes to the wording arising from a design solution, e.g. if we reformat the dropdown menus to accommodate the language selector, say.)

Does the above approach sound good to you? That way, you won't need to make the triaging decision each time and it'll be quicker to audit that each in-progress issue has a UXW assignee.

@seanlip
Copy link
Member

seanlip commented Jan 5, 2024

Also assigning @ConorMack as UXD since I believe he's looking into this (@ConorMack please feel free to post any updates to this thread, thanks!)

@kmuir1991
Copy link

@seanlip yep, that sounds fine to me! It sounds like the rest of the UXW team is okay with me assigning them some of these remaining projects, so I'm going to give this one to @tydesignit

@luoyi99 luoyi99 moved this from Not Started to In Progress in UX Design + UX Writing Projects Board Oct 15, 2024
@seanlip seanlip changed the title [Tarnsferred from Web repo] New designs of top navigation bar for samsung galaxy fold devices. [Transferred from Web repo] New designs of top navigation bar for samsung galaxy fold devices. Nov 10, 2024
@S4v8n S4v8n moved this from In Progress to Waiting on UX Lead Approval in UX Design + UX Writing Projects Board Jan 28, 2025
@S4v8n
Copy link

S4v8n commented Feb 10, 2025

Hi @tamiorendain @davishedrick @aileenyesand, Hope you are all well. We need a lead UXW to review this project for UXW lead approval. Once there are no changes required, please check mark the box "UXW Lead approval" in this project. If revisions are required please add comments on the design file for the designer respond. Thank you in advance.

@tamiorendain
Copy link

Hi @S4v8n, got it! Added this to our task list

@davishedrick
Copy link

Hey @S4v8n we're prepared to sign off since there really isn't much language to review. Thanks!

@S4v8n
Copy link

S4v8n commented Feb 12, 2025 via email

@seanlip
Copy link
Member

seanlip commented Mar 10, 2025

Note: oppia/oppia#22050 (comment) is a duplicate of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Handed off to PM 🟢
Development

No branches or pull requests

9 participants