Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-network: link bonding policy not propagated #7683

Open
1 task done
jpsollie opened this issue Mar 17, 2025 · 4 comments
Open
1 task done

luci-mod-network: link bonding policy not propagated #7683

jpsollie opened this issue Mar 17, 2025 · 4 comments

Comments

@jpsollie
Copy link

jpsollie commented Mar 17, 2025

Is there an existing issue for this?

  • I have searched among all existing issues (including closed issues)

screenshots or captures

when creating a link aggregation interface with the new netifd system instead of luci-proto-bonding (which was removed a few weeks ago), I enter in luci the option "active-backup" (view screenshot):

Image

But in /proc/net/bondjp it states round-robin:

cat /proc/net/bonding/bondjp 
Ethernet Channel Bonding Driver: v6.6.83

Bonding Mode: load balancing (round-robin)
MII Status: up
MII Polling Interval (ms): 0
Up Delay (ms): 0
Down Delay (ms): 0
Peer Notification Delay (ms): 0

Slave Interface: lan1
MII Status: up
Speed: 1000 Mbps
Duplex: full
Link Failure Count: 0
Permanent HW addr: ba:96:7a:2e:1b:71
Slave queue ID: 0

Slave Interface: sfp-lan
MII Status: up
Speed: 2500 Mbps
Duplex: full
Link Failure Count: 0
Permanent HW addr: ba:96:7a:2e:1b:72
Slave queue ID: 0
root@APBureau4:~# 

There's also nothing written in /etc/config/networks about an active-backup policy (though I don't know whether this should be, the documentation isn't clear):

config device
        option type 'bonding'
        option name 'bondjp'
        list ports 'lan1'
        list ports 'sfp-lan'
        option primary 'sfp-lan'
        option multicast_router '2'
        option multicast_fast_leave '1'
        option promisc '1'

IMO this is a bug, and I hope the missing parameter can be added, but if someone could help me to verify whether uci knows it should be active-backup (which makes it a main openwrt bug), it'd love to hear

Actual behaviour

a newly created link aggegation interface is started in round-robin mode, whereas it should be as active-backup

Expected behaviour

the interface is started as active-backup

Steps to reproduce

Image

Additional Information

{
        "kernel": "6.6.83",
        "hostname": "APBureau4",
        "system": "ARMv8 Processor rev 0",
        "model": "Bananapi BPI-R4",
        "board_name": "bananapi,bpi-r4",
        "rootfs_type": "squashfs",
        "release": {
                "distribution": "OpenWrt",
                "version": "SNAPSHOT",
                "firmware_url": "https://downloads.openwrt.org/",
                "revision": "r0+29008-0aaabffdea",
                "target": "mediatek/filogic",
                "description": "OpenWrt SNAPSHOT r0+29008-0aaabffdea",
                "builddate": "1742051600"
        }
}

What browsers do you see the problem on?

No response

Relevant log output

@systemcrash
Copy link
Contributor

Since active-backup is the default, perhaps it is elided, with the assumption that netifd also chooses that.

Please try to add the explicit config line to /etc/config/networks

policy 'active-backup'

resulting in:

config device
        option type 'bonding'
        option name 'bondjp'
        list ports 'lan1'
        list ports 'sfp-lan'
        option primary 'sfp-lan'
        option multicast_router '2'
        option multicast_fast_leave '1'
        option promisc '1'
        policy 'active-backup'

and reload that interface or restart networking. Let us know your results.

@systemcrash
Copy link
Contributor

Any ideas from @hitech95 ?

@jpsollie
Copy link
Author

policy active-backup didn't do what we expected it would do ... do I need to forward this bug to the main repository?

@hitech95
Copy link
Contributor

Any ideas from @hitech95 ?

I'll take a look later today.
Thi might be a bug in both luci and netifd.

policy active-backup didn't do what we expected it would do ... do I need to forward this bug to the main repository?

Can you better explain the expected result so I can later run a test on your config?
What was the configuration with luci-proto-bonding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants