-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in [OUT] parameters handling #287
Comments
Is there a workaround or fix for this? I've got a small test framework that relies on libvlc_log_get_context to scrape debug info from some vlc modules that I've written. My python C binding knowledge is very limited so please assume I know nothing as far as that goes. |
There is a manual workaround for now, by monkey-patching the vlc function after loading the vlc module
(waiting for some time to dedicate for properly fixing this, or some contribution for it) |
@yanns1 could maybe have some ideas about it. |
I can't help with a proper fix (sorry), but your workaround is great. Thanks. |
See #289. |
The
libvlc_log_get_context
is improperly wrapped in the latest bindings version: parameters marked as [OUT] are not properly parsed as such, as indicated by thegenerate.py -dc
output, as well as the generated code. The current versionhttps://github.com/oaubert/python-vlc/blob/master/generated/3.0/vlc.py#L7305 states that the parameter signature is
( (1,), (1,), (1,), (2,), ),
(3 in-parameters, 1 out parameter) while the previous version of the bindings (before the tree-sitter change) correctly gets((1,), (2,), (2,), (2,),)
:python-vlc/generated/3.0/vlc.py
Line 5151 in 587d626
This is a regression, which also happens to other functions (e.g.
libvlc_media_tracks_get
,libvlc_media_slaves_get
...) but sometimes is correct (e.g.libvlc_video_get_size
,libvlc_video_get_cursor
).The text was updated successfully, but these errors were encountered: