Bug: "Import Error _DEFAULT_CA_CERTS" With tornado 5.0

[tommyyz]

Since tornado updated to 5.0, the latest version of pynsq has conflict with this new tornado:

>>> import nsq
Traceback (most recent call last):
  File "/Users/tom/Virtualenvs/athena/lib/python3.5/site-packages/nsq/async.py", line 31, in <module>
    from tornado.simple_httpclient import _default_ca_certs as default_ca_certs
ImportError: cannot import name '_default_ca_certs'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/tom/Virtualenvs/athena/lib/python3.5/site-packages/nsq/__init__.py", line 29, in <module>
    from .async import AsyncConn
  File "/Users/tom/Virtualenvs/athena/lib/python3.5/site-packages/nsq/async.py", line 34, in <module>
    from tornado.simple_httpclient import _DEFAULT_CA_CERTS
ImportError: cannot import name '_DEFAULT_CA_CERTS'

This bug causes huge consequences on my application and plz fix this ASAP.
Currently my way to fix this bug is to put these lines in requirements.txt to force tornado use 4.5.3:

tornado==4.5.3
pynsq

[tommyyz]

oooops I just found out pynsq-0.8.3 fixed that issue. ORZ.. waiting for this release!

[ploxiln]

Yup, still, this is a good additional note for #185

[kimixsx]

Encountered this issue + 1, where did you find out pynsq-0.8.3 fixed it?

[ploxiln]

the change in pynsq-0.8.3 is to require tornado < 5.0

[tommyyz]

@ploxiln yeah I checked the changes hahaha...

[yxy]

same issue

[memotype]

What is the status on this issue? I just ran "pip3 install pynsq" and trying to import it I get this error. Seems odd that this issue would still be open 6 months later being as it renders the module completely unusable...

[ploxiln]

This module is usable if you use tornado < 5.0
(which would be enforced by https://github.com/nsqio/pynsq/blob/master/setup.py#L35 but there has not yet been a pynsq release with that constraint). I suggest you pip3 install tornado==4.5.3

[ploxiln]

The setup.py checks for tornado<5.0 but we haven't made any release since that change. There have also been a couple of python3-related fixes since then, so maybe it's time for another release @jehiah @mreiferson ?

(even though the long-awaited tornado-5.0 compatibility, which I said I would work on, has not been done yet ...)

[mreiferson]

Given that actual compatibility is a ways off, yea, should probably issue a point release for the patch.

[SylphiaWindy]

Why closed this while not fixed?

[ploxiln]

the latest release 0.8.3 prevents you from using pynsq with tornado >= 5.0 (so you can use at latest tornado 4.5.3) so you won't run into this particular error

compatibility with tornado-5.x is still a needed feature/bugfix and not forgotten

[SylphiaWindy]

Alright, I see. How about just using None for default ca_certs, or import certifi and using certifi.where

[xiaoliuhust]

what's the time of next release of pynsq, i want to use pynsq with tornado 5.1

[pirm-in]

Hi there!
Is there any update about the support for tornado-5? Compatibility with the asyncio loop would be awesome. maybe a feature branch where we could help?

Or is there any other way to use pynsq, when i already have asyncio in place. I am currently struggling with combining the two, because i already have a blocking asyncio-loop.
Thanks!

Edit:
Ok, i just found #185
Is it only the merge conflicts, or is there more to it?

[mreiferson]

please continue discussion in #185