Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable threshold for The module ... is taking ...ms to serialize #13627

Closed
1 task done
sovcharenko opened this issue May 29, 2024 · 2 comments
Closed
1 task done
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@sovcharenko
Copy link

sovcharenko commented May 29, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

We're consistently getting

The module "InternalCoreModule" is taking 35.35ms to serialize during start up when app runs on not super fast CPU or when CPU throttling kicks in.

There is no way to configure threshold as it's hardcoded to 10ms

https://github.com/nestjs/nest/blob/aa7538ffbe8608c41ece2a035b872e5032f57763/packages/core/injector/module-token-factory.ts#L37C4-L42C6

Describe the solution you'd like

Add configuration option to increase warning threshold or disable this check altogether.

Teachability, documentation, adoption, migration strategy

N/A i think

What is the motivation / use case for changing the behavior?

Reduce warnings noise

@sovcharenko sovcharenko added needs triage This issue has not been looked into type: enhancement 🐺 labels May 29, 2024
@kamilmysliwiec
Copy link
Member

#13336

@sovcharenko
Copy link
Author

sovcharenko commented Jun 3, 2024

@kamilmysliwiec i might be missing something but i don't think this is completed.

The PR you linked is the initial implementation that has 10ms hardcoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

2 participants