-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for themes that point to git repositories #37
Comments
As of commit 0685244, themes are also now found in |
As far as enabling remote themes more specifically, beyond the user manually downloading them to their config directory, is there a standard way to translate Git URLs to raw file data? ie. edit: Gitea could also be tested if the syntax was perhaps changed to |
Also, would this support multiple themes inside a single repo? Or would each theme have to be its own repository? |
I think the idea is that each theme is its own repository, which makes sense since fomantic themes will generally need a build process of some kind. We can very easily provide a starting repository that a theme developer can simply fork, change some variables, and compile. With regards to downloading the Git repositories, there are three main options:
I recommend the first option. |
With the proper error messages, we could do 1, with a potential fallback to 2 if |
I like that strategy a lot. Let's do it. |
Adding on to this, |
Actually going to make a new issue for that. |
As of commit 0685244, the theme configuration is handled via the config.json file. I propose that a theme can be configured by simply referring to its Git repository, like so:
config.json
The first entry,
dark
, is a built-in theme that internally translates to a git repository.The second entry is a GitHub URL to the repository that contains the theme to be downloaded directly.
The third entry isn't a GitHub URL, but it IS a valid git repository, and will be interpreted the same.
Andesite can then be responsible for reading the configuration at runtime, downloading the theme from the provided Git repository (with a very specific structure), placing the files into the
.andesite/theme-name/
folder, and serving from there like previously.Having the ability to install themes like this makes both configuration and 3rd party theme creation very easy.
The text was updated successfully, but these errors were encountered: