Capture CPU profiles in audit

[jarretlavallee]

Proposed change

Please add CPU profile collection to audit when passing --server-profiles.

Use case

CPU profile collection is often useful for diagnostics and would be worthwhile to collect when collecting the other profiles. CPU profile collection is available through profilez in 2.10.19+ and has been implemented in nats server request profile cpu.

Contribution

No response

[ripienaar]

CPU profiles is the odd one out that takes a while to gather so we need to do something extra there over what the gather command handles today.

We should also add the other profiles that we have now that audit isnt gathering

natscli/cli/server_request_command.go

Lines 230 to 235 in 09054dd

	if c.profileName == "cpu" {
	// people can use --timeout to adjust the wait time
	opts.Duration = options.DefaultOptions.Timeout
	// but we have to then bump timeout to give the network time
	options.DefaultOptions.Timeout = options.DefaultOptions.Timeout + 2*time.Second
	}

[jarretlavallee]

Good point. Would it be possible to have it opt in or some other mechanism to include other files in the audit where we could have them run a CPU profile in advance and save it to that directory?

[ripienaar]

gather is already slow, I think its ok to make it a bit slower :) I think its useful by default to have this so we should just always grab it. Worse is forgetting and then needing it on a hard to reproduce issue

[jarretlavallee]

Sounds good