Skip to content

issues Search Results · repo:mikejohnson51/hydrofab language:R

Filter by

18 results
 (53 ms)

18 results

inmikejohnson51/hydrofab (press backspace or delete to remove)

mikejohnson51/hydrofab
Incomplete graph in DAG check

https://github.com/mikejohnson51/hydrofab/blob/78e8450cd3b8b669f1263b69b3278909432b7658/R/hyaggregate_utils.R#L95 From the igraph documentation on graph_from_data_frame, I think the graph you make from ...
  • hellkite500
  • 1
  • Opened 
    on Nov 30, 2023
  • #28

mikejohnson51/hydrofab
Call `get_hydrofabric` without a ScienceBase account?

For the function get_hydrofabric, would it be possible to call sbtools download functions or download functions from other packages that don t require a user to authenticate with a ScienceBase account? ...
  • lucyrandrews
  • Opened 
    on Oct 2, 2023
  • #27

mikejohnson51/hydrofab
CLI ready version of all processes

Over here, we started to build a CLI for hydrofabric subsetting. In addition, I would like to include CLI utilities for: - [ ] 1. Reference Feature Subsetting - [ ] 2. Refactoring - [ ] 3. Aggregation ...
  • mikejohnson51
  • Opened 
    on Jul 24, 2023
  • #26

mikejohnson51/hydrofab
Inclusion of island catchment "type" feature within divides layer of the hydrofabric

To properly discard island features within an unstructured mesh generation of a given VPU region of the hydrofabric, we need to add a flag within the type column of the divides layer in the hydrofabric ...
  • jduckerOWP
  • Opened 
    on Jun 20, 2023
  • #25

mikejohnson51/hydrofab
Forcings Metadata layer for hydrofabric

Previous versions included an *ext.gpkg that included a forcing_dem_attributes layer. Although the NextGen forcings workstream does not need any more weights, we still need the following variables for ...
  • jduckerOWP
  • Opened 
    on Jun 20, 2023
  • #24

mikejohnson51/hydrofab
Error check on clean_geometries() keep value

I am proposing to add a check on the keep argument in hydrofab::clean_geometries() to make sure that keep is 0 and = 1. This is a requirement for the rmapshaper::ms_simplify function that runs at the ...
  • anguswg-ucsb
  • Opened 
    on May 31, 2023
  • #23

mikejohnson51/hydrofab
Layering flowpaths over catchment plots

Hi Mike - I was wondering if we could layer the flowpaths over the catchment plots? Thanks, Wanru
  • WanruWu-NOAA
  • 1
  • Opened 
    on Nov 1, 2022
  • #19

mikejohnson51/hydrofab
Enforce network types in output

There are three type of hydrologic features 1. Network (flowpath and divide exist with share integer identifty) 2. Connector (flowline exists w/o divide) - right now aggregate_to_distribution drops ...
  • mikejohnson51
  • 2
  • Opened 
    on Nov 1, 2022
  • #17

mikejohnson51/hydrofab
flowpath to divide not 1:1 in aggregate output due to pipelines and such.

Some flowpath ids get dropped because we are using divide ids to seed the lookup table here: https://github.com/mikejohnson51/hydrofab/blob/master/R/merge_hydrofabrics.R#L83 This is causing some flowpath ...
  • dblodgett-usgs
  • 3
  • Opened 
    on Nov 1, 2022
  • #15

mikejohnson51/hydrofab
aggregate_to_distribution yields mulitpolygons with new refactor output

I am sure this does not have to do with the refactor output but exposes a gap in the aggregation logic: Screen Shot 2022-10-28 at 5 08 55 PM Red = uniform output Tan = input catchments 10015624, 10015623, ...
  • mikejohnson51
  • 2
  • Opened 
    on Oct 28, 2022
  • #14
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub