Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic host for GarnetServer #579

Closed
Meir017 opened this issue Aug 9, 2024 · 2 comments
Closed

Use generic host for GarnetServer #579

Meir017 opened this issue Aug 9, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Meir017
Copy link
Contributor

Meir017 commented Aug 9, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Using the generic host https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host will simplify how we bootstrap the server

Describe the solution you'd like

wire up using DI the dependencies that are created manually.

Describe alternatives you've considered

No response

Additional context

see the manual configuration https://github.com/microsoft/garnet/blob/main/libs/host/GarnetServer.cs#L151C13-L210C57

@badrishc badrishc added the help wanted Extra attention is needed label Aug 9, 2024
@Meir017
Copy link
Contributor Author

Meir017 commented Aug 12, 2024

#394 starts doing this,

I think we can take that PR without the windows service code as I think it's still in discussion

@badrishc
Copy link
Collaborator

Mostly addressed by #614 - feel free to create PR if you have more ideas in this space.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants