Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make usage of name field in OpenAI messages optional in OpenAIChatCompletionClient #6034

Open
1 task done
ekzhu opened this issue Mar 20, 2025 · 2 comments · May be fixed by #6056
Open
1 task done

Make usage of name field in OpenAI messages optional in OpenAIChatCompletionClient #6034

ekzhu opened this issue Mar 20, 2025 · 2 comments · May be fixed by #6056
Labels
good first issue Good for newcomers help wanted Extra attention is needed proj-extensions
Milestone

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 20, 2025

Confirmation

  • I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.

Issue body

Many "openai-compatible" model providers don't support the name field in message.

e.g, https://console.groq.com/docs/openai

Add include_name_in_message parameter to BaseOpenAIChatCompletionClient, and add to BaseOpenAIClientConfiguration. Default should be True.

Then, in user_message_to_oai and assistant_message_to_oai, we decide whether to use the name field based on the option set.

For model APIs that don't support this field, we document in the usage guide about this option.

@ekzhu ekzhu added good first issue Good for newcomers help wanted Extra attention is needed proj-extensions labels Mar 20, 2025
@ekzhu ekzhu added this to the 0.4.x-python milestone Mar 20, 2025
@tongyu0924
Copy link
Contributor

Can I work on this issue?

@ekzhu
Copy link
Collaborator Author

ekzhu commented Mar 20, 2025

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed proj-extensions
Projects
None yet
2 participants