-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 2p2e4 et al? #4624
Comments
I was wondering if
I could keep going on details, but I guess the more important question is whether the overall direction is a good one. I think so, at least in the sense that it better follows the convention, the convention seems to make sense (in general and as applied here), and I'm not thinking of cases in which including the "equals 4" in the name would ever disambiguate anything. I suppose there is the possibility that names as short as |
Also from the conventions page: So when introducing a new labelling scheme, you have to update the conventions page in this regard as well. |
FWIW in MM0 I used names like Note: Any changes to this set of theorems will also need to be reflected in the mmj2 macro which generates proofs of arithmetic statements. (Or maybe not? Seems the base case theorems are all picked up automatically in transformations.js. But if there are any other implementations of this algorithm floating around they may need updating.) Also, |
I was wondering about this with respect to a different rename. What would "alias" mean? Have a theorem at the old name which is marked as discouraged, which has the same statement as the new name, and which I guess has a one step proof in terms of the new name? If we want to reuse the name we do have precedent for that, the "Note on naming" at https://us.metamath.org/mpeuni/trud.html . But I don't know if there is an existing example of renaming a "well-known" theorem without reusing the old name. |
The idea of an alias is already present in set.mm. con4 is an alias for ax-3. |
It looks like "p" et al is used a bit more extensively than stated, like in cnambpcma --> cn ((a-b)+c)-a It's going to be pretty hard to find all of these edge cases manually though. My affected theorem list searched for |
That looks like nonstandard naming, and it's in @avekens 's mathbox so we don't enforce the naming convention as strictly there. We don't use variable names in theorem names normally. |
I found another bunch of exceptions: mulm1, adddirp1d To avoid spamming the issue, I'll just edit this comment when I stumble on exceptions. |
Yes, ~cnambpcma (and ~cnapbmcpd) were just experiments. They could be renamed as "subaddsubdif" and "addsubaddasscom" or something similar. I do not cling to these labels. |
In my opinion, there is no need for any change: "p" and "m" are shorter than "add" and "sub", and the listed examples like 7m1e6 are intuitive and nice to read. Wheres "cos0" clearly means "cos(0)", it would not be so clear for "7m1". Therefore, the convention makes sense for "cos", but not for "m". And saving 2-3 characters is not worth the effort. |
conventions-labels states:
(last sentence bolded)
Given this, should 2p2e4 et al be renamed 2p2? I think removing it does make the theorems a little bit easier to use; an exaggerated illustration of this is 235t711
Note that theorems like 1e0p1 would presumably be renamed to say, e0p1
Affected theorems
(Not affected? and not already in the format:)
The text was updated successfully, but these errors were encountered: