Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a save button to the bottom of the edit modal #7

Open
dmnewcomb opened this issue May 13, 2024 · 2 comments
Open

Add a save button to the bottom of the edit modal #7

dmnewcomb opened this issue May 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmnewcomb
Copy link
Contributor

The user experience is pretty unclear regarding saving changes. We should clarify that with some type of save button experience.

This mockup design can be changed up. Maybe there's a background, or different font styling, or some color change on hover? The basic idea should hold though that by clicking this button on the bottom of the modal, the changes save. And by clicking X at the top right, the changes do not persist.

Screenshot 2024-05-13 at 7 54 40 AM
@dmnewcomb dmnewcomb added the enhancement New feature or request label May 13, 2024
@dmnewcomb
Copy link
Contributor Author

Icons are coming from https://feathericons.com/ so you could the save icon for the design.

@dmnewcomb
Copy link
Contributor Author

Code mostly found in editModal.jsx and editModal.css. Design-wise, the save button should be persistent so if there's internal scrolling due to large number of editable fields, we want to make sure the user can always click save. Keep that button fixed to the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants