Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update GraphQL tests Client.php for case-insensitive substring comparation #39713

Open
5 tasks
m2-assistant bot opened this issue Mar 6, 2025 · 0 comments · May be fixed by #39712
Open
5 tasks

[Issue] Update GraphQL tests Client.php for case-insensitive substring comparation #39713

m2-assistant bot opened this issue Mar 6, 2025 · 0 comments · May be fixed by #39712
Labels
Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 6, 2025

This issue is automatically created based on existing pull request: #39712: Update GraphQL tests Client.php for case-insensitive substring comparation

Description (*)

use case-insensitive comparation for headers

Related Pull Requests

Fixed Issues (if relevant)

  1. none

Manual testing scenarios (*)

When some custom graphql tests work with cookies the core client works unexpectedly.
Using case-insensitive substring comparation fixes the problem.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Mar 6, 2025 that will close this issue
Open
6 tasks
@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.x Indicates original Magento version for the Issue report. labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GraphQL tests Client.php for case-insensitive substring comparation ilnytskyi/magento2
1 participant
@engcom-Bravo