Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQl] Route query infinite loop #39707

Open
1 of 5 tasks
rybkinevg opened this issue Mar 5, 2025 · 5 comments · May be fixed by #39708
Open
1 of 5 tasks

[GraphQl] Route query infinite loop #39707

rybkinevg opened this issue Mar 5, 2025 · 5 comments · May be fixed by #39708
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p4 Indicates original Magento version for the Issue report.

Comments

@rybkinevg
Copy link

Preconditions and environment

  • Magento version: 2.4.7-p4

Steps to reproduce

  1. Go to Magento Admin -> Marketing -> SEO & Search -> URL Rewrites
  2. Create a new URL rewrite via Add URL Rewrite with following values:
    • Create URL Rewrite = Custom
    • Request Path = test
    • Target Path = test
  3. Send the following GraphQl query:
{
  route(url: "/test") {
    relative_url
  }
}

Expected result

{
  "errors": [
    {
      "message": "No such entity found with matching URL key: test",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "route"
      ],
      "extensions": {
        "category": "graphql-no-such-entity"
      }
    }
  ],
  "data": {
    "route": null
  }
}

Actual result

The request have been cycled in the infinite loop, and some day will fall with timeout

Additional information

The example above is synthetic, but custom URL rewrite entity types will be affected by this issue.

For example, if we have the Blog module with Post entity, and we are not going to show posts via Magento frontend (so we do not have the frontend controllers) we will fetch them via GraphQl queries and show on the custom frontend.

We will create the custom URL rewrite entity type and resolver for it:

enum UrlRewriteEntityTypeEnum {
    BLOG_POST
}

Also we will create the URL rewrite entry for post with the following values:

  • Create URL Rewrite = Custom
  • Request Path = blog/some-post-title
  • Target Path = blog/some-post-title

When frontend will query the route it will fall with timeout.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Mar 5, 2025

Hi @rybkinevg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@rybkinevg rybkinevg linked a pull request Mar 5, 2025 that will close this issue
5 tasks
@engcom-Bravo engcom-Bravo self-assigned this Mar 5, 2025
Copy link

m2-assistant bot commented Mar 5, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p4 Indicates original Magento version for the Issue report. label Mar 5, 2025
@engcom-Bravo
Copy link
Contributor

Hi @rybkinevg,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.kindly refer the screenshot.

Image

We are getting response as null.could you please let us know if we are missing anything and please try to reproduce the issue in Latest 2.4-develop instance.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Mar 6, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Mar 6, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Mar 6, 2025
@rybkinevg
Copy link
Author

rybkinevg commented Mar 6, 2025

Hi, @engcom-Bravo !

Thanks for your reply, but I am confirming that the issue is reproducible in 2.4-develop, I will describe steps which I done:

  1. I installed the fresh Magento instance from 2.4-develop branch
  2. Passed basic installation steps (DB setup, install command, admin setup)
  3. Created a new URL Rewrite with following values:
  • Create URL Rewrite = Custom
  • Request Path = test
  • Target Path = test
Image Image
  1. I configured the request timeout to 1 min (60000 ms), screenshot taken from Bruno HTTP client:
Image
  1. I send the following request and waited for 1 min:
{
  route(url: "/test") {
    relative_url
  }
}
Image
  1. I added some debug info to the app/code/Magento/UrlRewriteGraphQl/Model/Resolver/AbstractEntityUrl.php::findFinalUrl:
    private function findFinalUrl(UrlRewrite $urlRewrite): UrlRewrite
    {
        $count = 0;

        do {
            $nextUrlRewrite = $this->findUrlFromRequestPath(
                $urlRewrite->getTargetPath(),
                (int) $urlRewrite->getStoreId()
            );
            if ($nextUrlRewrite) {
                $urlRewrite = $nextUrlRewrite;
            }

            if ($count > 30) {
                die('I am in an endless loop');
            }

            $count++;
        } while ($nextUrlRewrite);

        return $urlRewrite;
    }
  1. I resend the route request:
Image

UPD I also double checked that the route query resolver in 2.4-develop branch still extends from the AbstractEntityUrl class and calling the parent::resolve() method which has the findFinalUrl method where the problem with endless loop appears

@gabrieldagama
Copy link
Contributor

@magento give me a 2.4-develop instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p4 Indicates original Magento version for the Issue report.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants