Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message queue topology is not considered in setup:db:status check #38225

Open
1 of 5 tasks
mfickers opened this issue Nov 27, 2023 · 8 comments · May be fixed by #39698
Open
1 of 5 tasks

Message queue topology is not considered in setup:db:status check #38225

mfickers opened this issue Nov 27, 2023 · 8 comments · May be fixed by #39698
Assignees
@ajith107
Labels
Area: Framework Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@mfickers
Copy link
Contributor

Preconditions and environment

  • Magento 2.4.6-p3
  • RabbitMQ configured

Steps to reproduce

  1. Run setup:upgrade to make sure db schema and data patches are up to date
  2. Add a new binding inside a queue_topology.xml file
  3. Run setup:db:status

Expected result

  • Command will return exit code 2
  • User is informed that setup:upgrade is needed

Actual result

  • Command returns exit code 0
  • Output is "All modules are up to date"

Additional information

Magento_Amqp module contains a recurring setup script that will upgrade the queue topology: \Magento\Amqp\Setup\Recurring. Updates to the topology configuration will only take effect when setup:upgrade is run.

The command setup:db:status should inform the user if a setup:upgrade is needed or not. It is used by deployment scripts like the Magento 2 recipe of Deployer. If the command returns exit code 0, then setup:upgrade is skipped during deployment and the message queue topology might be out of date.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 27, 2023

Hi @mfickers. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Dash engcom-Dash added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. labels Nov 28, 2023
@engcom-November engcom-November self-assigned this Dec 4, 2023
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 4, 2023

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @mfickers,

Thank you for the report and collaboration!

We were able to verify this issue on 2.4-develop.
As mentioned in the steps we added a new binding inside queue_topology.xml, and ran the setup:db:status command.
The topology binding was not considered and we got the the exit code 0 with the message "All modules are up to date".

Hence confirming this issue.

Thank you.

@engcom-November engcom-November added Component: Setup Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 5, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10641 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 5, 2023

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 5, 2023
@hostep hostep mentioned this issue Jan 3, 2024
Closed
5 tasks
@Vigneshmuthusamy
Copy link

@mfickers @engcom-Hotel @engcom-November @engcom-Dash Any update on this issue? It's needed badly to reduce deployment time in adobe commerce

@engcom-Hotel
Copy link
Contributor

Hello @Vigneshmuthusamy,

As I can see the related JIRA is still in the implementation phase. We will update you whenever it will mark as done, but meanwhile someone from community also raise the PR to fix this issue.

Thanks

@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
@ajith107
Copy link
Contributor

ajith107 commented Mar 4, 2025

@magento I am working on this

@ajith107 ajith107 linked a pull request Mar 4, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajith107 ajith107

Labels
Area: Framework Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Message Queue Changes Tracking in setup:db:status Command ajith107/magento2
7 participants
@Vigneshmuthusamy @mfickers @engcom-Hotel @engcom-November @engcom-Dash @ajith107 @github-jira-sync-bot