Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special Price To Date is wrongly validated on applySpecialPrice #39169

Open
5 tasks
tcoluke opened this issue Sep 13, 2024 · 19 comments · May be fixed by #39690
Open
5 tasks

Special Price To Date is wrongly validated on applySpecialPrice #39169

tcoluke opened this issue Sep 13, 2024 · 19 comments · May be fixed by #39690
Assignees
@KrasnoshchokBohdan
Labels
Area: APIs Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.4-p7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@tcoluke
Copy link

tcoluke commented Sep 13, 2024 •
edited
Loading

Preconditions and environment

  • Actually reproduced on Magento 2.4.4-p7 but nothing is changed in recent version

Steps to reproduce

Use Rest API to set special price
/rest/default/V1/products/special-price

provide body like

{
  "prices": [
    {
      "price": 5,
      "store_id": 1,
      "sku": "1181",
      "price_from": "2024-08-02 17:00:00",
      "price_to": "2024-09-12 17:00:00",
      "extension_attributes": {}
    }
  ]
}

then check your price on front-end
admin or whatever

your special price will be visible until tomorrow 17

so instead expire at 2024-09-12 17:00:00 it will expire on 2024-09-13 17:00:00

because of validation on Magento\Catalog\Model\Product\Type\Price::calculateSpecialPrice

            if ($this->_localeDate->isScopeDateInInterval($store, $specialPriceFrom, $specialPriceTo)) {
                $finalPrice = min($finalPrice, (float) $specialPrice);
            }

instead of check in range from -> to
it add to end date 1 day

Magento\Framework\Stdlib\DateTime\Timezone::isScopeDateInInterval

maybe it can be used for other validation but for real not for calculateSpecialPrice it should be in range from -> to set by admin

Expected result

Product special price should expire on date set by admin or 3rd party system by REST API

Actual result

End date is missed and expire day after

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Sep 13, 2024

Hi @tcoluke. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Sep 13, 2024
@tcoluke
Copy link
Author

tcoluke commented Sep 13, 2024

@magento give me 2.4-develop instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@tcoluke
Copy link
Author

tcoluke commented Sep 13, 2024

@magento give me 2.4-develop instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Bravo engcom-Bravo added Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.4-p7 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Sep 16, 2024
@engcom-Bravo engcom-Bravo self-assigned this Sep 16, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Sep 16, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@tcoluke
Copy link
Author

tcoluke commented Sep 17, 2024

@magento give me 2.4-develop instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@tcoluke
Copy link
Author

tcoluke commented Sep 19, 2024

@magento give me 2.4-develop instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@tcoluke
Copy link
Author

tcoluke commented Sep 19, 2024

@engcom-Bravo are you working on it ? and can you also investigate why I can't get magento instance ?

@engcom-Bravo
Copy link
Contributor

Hi @tcoluke,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-09-25 at 11 56 39 Screenshot 2024-09-25 at 11 56 30

Special price is still applied even after expired.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Area: APIs labels Sep 25, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13130 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Sep 25, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@KrasnoshchokBohdan
Copy link
Contributor

@magento I am working on this

KrasnoshchokBohdan added a commit to KrasnoshchokBohdan/magento2 that referenced this issue Mar 1, 2025
@KrasnoshchokBohdan
magento#39169: Special Price To Date is wrongly validated on applySpe…
9111182 
…cialPrice
@KrasnoshchokBohdan KrasnoshchokBohdan linked a pull request Mar 1, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrasnoshchokBohdan KrasnoshchokBohdan

Labels
Area: APIs Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.4-p7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
4 participants
@engcom-Bravo @github-jira-sync-bot @KrasnoshchokBohdan @tcoluke