Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping of text #1551

Open
1 of 7 tasks
ir0nh34d opened this issue Feb 11, 2025 · 4 comments
Open
1 of 7 tasks

Clipping of text #1551

ir0nh34d opened this issue Feb 11, 2025 · 4 comments
Labels
Bug Renderer Text rendering issues, including CoreText renderer
Milestone

Comments

@ir0nh34d
Copy link

Steps to reproduce

  1. .gvim configured with: set guifont=-monospace-Thin:h14
  2. Open MacVim, enter terminal mode with :term
  3. Type a command that has a a letter with character that drops below the main characters like "git update"

Image

Expected behaviour

The bottom of the characters should not be clipped (i.e. the 'g' in the screenshot should show the bottom of the 'g')

Version of Vim and architecture

MacVim r180.2 (Vim 9.1.1000)

Environment

MacOS 15.3.1

How MacVim was installed

Compiled from git via GitHub

Logs and stack traces

Vim configuration where issue is reproducable

guifont=-monospace-Thin:h14

Issue has been tested with given configuration

  • by running MacVim.app from GUI macOS interface
  • by running vim/gvim/etc installed by MacVim
  • by running other versions of vim (e.g. /usr/bin/vim)

Issue has been tested with no configuration

  • by running mvim --clean (or gvim, supplied by MacVim distribution)
  • by running vim --clean (in terminal, supplied by MacVim distribution)
  • by running vim --clean (in terminal, other suppliers, e.g. /usr/bin/vim)

Other conditions

  • The both Homebrew packages "vim" and "macvim" are installed
@ychin
Copy link
Member

ychin commented Feb 11, 2025

Hmm that's weird. I'm not seeing on my local machine. If you don't mind, can you try to run a clean instance of Vim and see if it reproduces? You can do that by either mvim --clean or within MacVim, go to File -> New Clean Window.

Also do you mind showing me your MacVim settings? You can do so by doing the following:

defaults read org.vim.MacVim | grep MM

Also, have you seen this outside of the terminal or in other situations?

@ir0nh34d
Copy link
Author

ir0nh34d commented Feb 11, 2025

Oddly, in a clean instance I don't see the issue.

Here are my MacVim settings:
MMAppearanceModeSelection = 3;
MMAutosaveColumns = 150;
MMAutosaveRows = 49;
MMCurrentPreferencePane = Advanced;
MMLastUsedBundleVersion = "180.2";
MMTopLeftPoint = "{220, 1008}";
MMUntitledWindow = 2;

Testing locally, it seems to be specific to the guifont being used:
guifont=-monospace-Thin:h14

@ir0nh34d
Copy link
Author

More testing:
guifont=-monospace-Thin:h14 - shows the issue
guifont=-monospace-Thin:h12 - shows the issue
guifont=-monospace-Thin:h15 - does not shows the issue

Could this be a calculation issue?

@ychin
Copy link
Member

ychin commented Feb 11, 2025

Ok I managed to reproduce this. It was easier to see on a non-retina screen. Will need to take a look first, as I'm hoping to push out r181 soon. Will need to decide if this fix goes in before that.

@ychin ychin added the Renderer Text rendering issues, including CoreText renderer label Feb 12, 2025
@ychin ychin added this to the Release 182 milestone Feb 12, 2025
@ychin ychin added the Bug label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Renderer Text rendering issues, including CoreText renderer
Projects
None yet
Development

No branches or pull requests

2 participants