Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTree concatenation, set operations sometimes corrupt their input trees #19

Closed
lorentey opened this issue Nov 4, 2016 · 1 comment
Closed

BTree concatenation, set operations sometimes corrupt their input trees #19

lorentey opened this issue Nov 4, 2016 · 1 comment
Labels
bug

Comments

@lorentey
Copy link
Collaborator

lorentey commented Nov 4, 2016 •
edited
Loading

In some cases, appending the same tree multiple times to a BTreeBuilder may corrupt the original (read-only) tree.

I am unable to reproduce this with constructs from 3.1.0, but it is reasonably easy to do it with the new bag operations on master.
@lorentey lorentey added the bug label Nov 4, 2016
lorentey added a commit that referenced this issue Nov 4, 2016
@lorentey
Fix missing child deduping in BTreeNode.shiftSlots, resulting in rare…
5854aa8 
… data corruption problems

This fixes issue #19.
@lorentey
Copy link
Collaborator Author

lorentey commented Nov 4, 2016

This was due to a missing makeChildUnique() call in BTreeNode.shiftSlots. Whew.

@lorentey lorentey closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorentey