Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move factories into tests #503

Open
pacrob opened this issue Feb 9, 2025 · 2 comments
Open

Move factories into tests #503

pacrob opened this issue Feb 9, 2025 · 2 comments
Assignees
@Khwahish29

Comments

@pacrob
Copy link
Member

pacrob commented Feb 9, 2025 •
edited
Loading

Description

The use of factories defined in libp2p/tools/factories is limited to testing. Which is good - factory-boy is for generating test fixtures. But they should then be defined within the tests folder, not in a public-facing one.

Motivation

Testing tools should not be in a public folder.

Current Implementation

It's pretty nested in there, so some care will be needed in extrication.

Are you planning to do it yourself in a pull request ?

Maybe
@Khwahish29
Copy link
Contributor

Hey @pacrob I would like to work on this issue!

@pacrob
Copy link
Member Author

pacrob commented Feb 19, 2025

@Khwahish29 all yours

@Khwahish29 Khwahish29 mentioned this issue Feb 21, 2025
Closed
@Khwahish29 Khwahish29 mentioned this issue Mar 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khwahish29 Khwahish29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pacrob @Khwahish29