Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection establishment time increase between tcp v9 and v10 #3029

Open
achingbrain opened this issue Mar 4, 2025 · 0 comments
Open

Connection establishment time increase between tcp v9 and v10 #3029

achingbrain opened this issue Mar 4, 2025 · 0 comments
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue

Comments

@achingbrain
Copy link
Member

achingbrain commented Mar 4, 2025 •
edited
Loading

To connect to another js-libp2p peer and send one byte takes 0.2s with @libp2p/[email protected] but 0.4s with @libp2p/[email protected].

An extra round-trip may have been added - it needs some investigation as to why.

Image

https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=04d78b7e02f35038bed154f5772cbeade2b87912

The relevant deps are:

Before

"@chainsafe/libp2p-noise": "^14.0.0"
"@chainsafe/libp2p-yamux": "^6.0.1"
"@libp2p/tcp": "^9.0.4"
"libp2p": "^1.0.5"

After

"@chainsafe/libp2p-noise": "^16.0.3"
"@chainsafe/libp2p-yamux": "^7.0.1"
"@libp2p/tcp": "^10.1.6"
"libp2p": "^2.8.0"
@achingbrain achingbrain added need/triage Needs initial labeling and prioritization help wanted Seeking public contribution on this issue good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization labels Mar 4, 2025
@achingbrain achingbrain changed the title Connection establishment increase round trips between tcp v9 and v10 Connection establishment tneincrease between tcp v9 and v10 Mar 4, 2025
@achingbrain achingbrain changed the title Connection establishment tneincrease between tcp v9 and v10 Connection establishment time increase between tcp v9 and v10 Mar 4, 2025
@panditdhamdhere panditdhamdhere mentioned this issue Mar 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: optimize TCP connection establishment time panditdhamdhere/js-libp2p
1 participant
@achingbrain