Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve KDS sync unit tests to remove 5s wait time #13101

Open
bartsmykla opened this issue Mar 13, 2025 · 2 comments
Open

Improve KDS sync unit tests to remove 5s wait time #13101

bartsmykla opened this issue Mar 13, 2025 · 2 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bartsmykla
Copy link
Contributor

Description

Right now, KDS sync tests wait 5 seconds before checking golden files to avoid flakiness. This was added in #13100 as a quick fix, but waiting that long seems unnecessary in most cases and slows down tests.

We should find a better way to check if sync is complete without using a fixed sleep time.
@bartsmykla bartsmykla added kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Mar 13, 2025
@lahabana
Copy link
Contributor

Ideally it'd be nice to have zoneInsight keep the latest hash as it would provide an easy to check if things are in sync.

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 17, 2025
@lukidzi
Copy link
Contributor

lukidzi commented Mar 17, 2025

Triage: We should think about how we can make it better. One idea is exposing the hash of the resources in ZoneInsight so we can compare that the version on zone is the same as on global. It could unblock initial sync on KDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahabana @bartsmykla @lukidzi