Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$EDITOR is not used #1367

Open
rosshadden opened this issue Feb 25, 2025 · 3 comments
Open

$EDITOR is not used #1367

rosshadden opened this issue Feb 25, 2025 · 3 comments
Labels

Comments

@rosshadden
Copy link

rosshadden commented Feb 25, 2025

Despite what it says in the docs, $EDITOR and $VISUAL do not seem to be used when they are set. This is not because GIT_/TIG_EDITOR are set and overriding them, as I do not have them set.

In my actual environment I have $EDITOR set and none of the others, but you can see this by invoking tig directly with no existing env vars:

# these do not work
EDITOR=nvim tig
VISUAL=nvim

# these do work
GIT_EDITOR=nvim tig
TIG_EDITOR=nvim tig
@koutcher
Copy link
Collaborator

They are but Git configuration variable core.editor has precedence over $EDITOR and $VISUAL. Ought to be mentioned in tig(1).

@rosshadden
Copy link
Author

I don't think that's what is happening here. My core.editor in my git config is $EDITOR.

@koutcher
Copy link
Collaborator

koutcher commented Mar 15, 2025

Maybe it should, but Tig currently does not support variables in core.editor / $GIT_EDITOR (i.e. unlike Git, the value is not interpreted by the shell when it is used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants