-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asking for a feature to view files or shortcut to change context. #26
Comments
Hi, thanks for your interest. I agree that the ergonomics of the search UI are not great right now. I have no idea what I'm doing when it comes to building UI 🌞. I am wondering whether the entire UI should be sticky so that it's always visible, as I mentioned in #23. A concern with that is that it might not work well on mobile devices (the search form is quite large relative to the screen size there). But mobile is not necessarily a big priority anyway; I just don't want to make it outright terrible. I have not had a lot of time to work on this project lately so I can't say when I'd be able to get to this. If you want to try making changes, go for it. This is the relevant svelte component. |
thank you! |
As for your question on HN:
I didn't actually know the builtin web UI of zoekt-webserver could do that. I will have to take a look at it some time. The zoekt-webserver API does not expose anything like this. They may just be doing something hacky in the web UI: making a search query for an exact file/repo match with very large context and hoping they get a single search result file for that query, and using it to render the "full" file. I've considered doing something like that in neogrok that in the past, but I decided I didn't want to do it because of how weird it feels 🌞. Linking out to GitHub (or whatever other VCS "forge" is configured during zoekt indexing) felt better to me. |
wait, there's a way to open file in vcs? |
oh, i see links on demo, but I don't have them when I run it locally, what could be the cause? |
running private gitlab repos. Strange, but this output of version commands zoekt-webserver --version |
looks like zoekt-git-index problem, when i copied neogrok repo it gave me links to github. Gonna take a look at zoekt-git-index. |
Try running |
hah, i already patched zoekt-git-index to handle my private gitlab url ahah. I'll checkout zoekt.web-url-type, thank you! |
FWIW, see https://github.com/sourcegraph/zoekt/blob/main/doc/indexing.md for the the git config options that are read from the repository. The documented supported values for I made sure to set |
I'm loving neogrok! Such an amazing UI, much better than native zoekt. I've already written a comment on HN, but just in case you don't use HN very often I'm asking for a feature here:)
Sometimes I need to see a more broad context of my search like 20 lines above and below of the match. I just simply open file in zoekt and read code from there. I can change context to more lines, but it kind feels terrible when you found your match you have to go to beginning of the page change context and then find the match again to see things around.
Sorry, it's my first time asking for a feature, not sure how it should be done properly. Also english is not my primary language:)
In case you don't have time I can try to implement it myself and create a PR, but it gonna get some time because I've never worked with typescript
The text was updated successfully, but these errors were encountered: