Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated functions from igraph/C #1177

Open
krlmlr opened this issue Jan 30, 2024 · 3 comments
Open

Avoid using deprecated functions from igraph/C #1177

krlmlr opened this issue Jan 30, 2024 · 3 comments
Assignees
Milestone

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Jan 30, 2024

Change to #define IGRAPH_DEPRECATED __attribute__ ((__deprecated__)) and fix errors, one PR for each deprecated function.

@krlmlr krlmlr added this to the upgrade-2 milestone Jan 30, 2024
@szhorvat
Copy link
Member

szhorvat commented Jan 30, 2024

igraph_hub_score() and igraph_authority_score() are deprecated because it makes sense to always compute these two scores together (for efficiency, interpretability and to make sure we get a matching pair). The new function is called igraph_hub_and_authority_scores().

I suggest merging these two in R under the name hits_scores(). See https://en.wikipedia.org/wiki/HITS_algorithm for where the name comes from. This name is short and there's precedence (both Mathematica and NetworkX use a variation of it).

In the longer term I also suggest deprecating the separate hub_score() and authority_score() functions in favour of the combined one (hits_scores()).

The TL;DR of this comment is a suggestion on what to call the combined function.

@maelle
Copy link
Contributor

maelle commented Feb 5, 2024

@szhorvat should this comment be a separate issue?

@krlmlr
Copy link
Contributor Author

krlmlr commented May 31, 2024

Running revdepchecks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants