Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage to the TriInterwrapper1Phase subchannel problem class #30068

Open
GiudGiud opened this issue Mar 10, 2025 · 0 comments
Open

Add coverage to the TriInterwrapper1Phase subchannel problem class #30068

GiudGiud opened this issue Mar 10, 2025 · 0 comments
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

Motivation

the triInterwrapper1Phase problem is not covered by any test that also computes enthalpy rise

This is a major miss in coverage, most of a central class.
Considering the unfortunate major code duplication in the problems, this is problematic

Design

Add a test for that problem

Impact

Follow our SQA practices
Improve coverage and confidence that the code is not deprecated
@GiudGiud GiudGiud added the T: task An enhancement to the software. label Mar 10, 2025
@GiudGiud GiudGiud mentioned this issue Mar 10, 2025
Merged
3 tasks
@GiudGiud GiudGiud added the C: Modules/Subchannel Tickets pertaining to the subchannel module label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud