Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertDateRange:assert - \Assert\Assertion::contains - parameters mixed up #20

Open
DangerLifter opened this issue Dec 13, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DangerLifter
Copy link

Call \Assert\Assertion::contains('/', $period); in AssertDateRange:assert has mixed up parameters!

@JeroenVanLeusden JeroenVanLeusden self-assigned this Dec 16, 2019
@JeroenVanLeusden
Copy link

@DangerLifter Can you describe what's the actual and expected response with certain parameters?

@DangerLifter
Copy link
Author

DangerLifter commented Dec 16, 2019

@DangerLifter Can you describe what's the actual and expected response with certain parameters?

I mean correct code should be:\Assert\Assertion::contains($period, '/'); Wrong parameters order. Called method definition is \Assert\Assertion::contains($string, $needle, $message = null, string $propertyPath = null, $encoding = 'utf8'): bool

@JeroenVanLeusden JeroenVanLeusden added the bug Something isn't working label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants