Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no bruteforce protection against login username / password available #455

Open
JessicaBachmann opened this issue Sep 30, 2013 · 2 comments · May be fixed by liqd/adhocracy#686
Open

no bruteforce protection against login username / password available #455

JessicaBachmann opened this issue Sep 30, 2013 · 2 comments · May be fixed by liqd/adhocracy#686
Assignees

Comments

@JessicaBachmann
Copy link
Contributor

Currently there's no protection against bruteforcing passwords of username. An attacker could use a predefined dictionary for getting the users password.

As a solution logins attemps, especially unsuccessfully ones, of last 24hrs need to be stored in a database. Therefor shortened IP address and timestamp should be used.

Serveral attemps could cause a delay(max 5 sec.) and after a numbered attemps (5?) user could be prompted to insert a capture to hinder several bruteforce attemps at a time.

@ghost ghost assigned JessicaBachmann Sep 30, 2013
@JessicaBachmann
Copy link
Contributor Author

I've created a new table. But after validating it I've noticed that we already have a table 'user'. So I wonder if we really need a new table. To avoid overhead wouldn't it be better to add columns to the existing table like unsuccessful login attemps and last login?

@wawe
Copy link
Contributor

wawe commented Oct 21, 2013

I'd argue that you'd want to record individual login attempts to have some flexibility, i.e. allowing 3 login attempts in 5 minutes or 30 login in 24 hours etc.
Having the history of failed login attempts is also necessary to recognize whether a sytematic attack on an account is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants