New image attachment system often fails #2401

shamefulCake1 · 2024-08-28T05:00:54Z

shamefulCake1
Aug 28, 2024

Sometimes it fails randomly
It fails if camera orientation is changed
It fails if camera is switched between back/front

I'll try to make a proper issue when i get to adb

harshad1 · 2024-09-10T06:44:53Z

harshad1
Sep 10, 2024
Collaborator

Orientation changes will likely break things.

What happens when you change orientation is that dialogs will get closed or closed and re-created without any relevant callbacks set. Working around this is non-trivial.

1 reply

shamefulCake1 Sep 22, 2024
Author

Orientation changes will likely break things.

What happens when you change orientation is that dialogs will get closed or closed and re-created without any relevant callbacks set. Working around this is non-trivial.

The old system didn't have this issue.

I might want to bisect it, but I think the issue only appeared one version away.

shamefulCake1 · 2025-01-05T11:00:46Z

shamefulCake1
Jan 5, 2025
Author

Something seems to have changed recently.

Stitching between the front and back cameras doesn't necessarily fall now, and it has generally been more stable.

Sometimes attachments still fail, but about 1 out of 3 almost always works.

0 replies

harshad1 · 2025-01-05T18:42:50Z

harshad1
Jan 5, 2025
Collaborator

If you are able to share a log with me that would be useful

0 replies

shamefulCake1 · 2025-01-07T02:49:37Z

shamefulCake1
Jan 7, 2025
Author

Here I have logcat | grep -i markor

01-07 09:46:49.402 23784 23784 W RecentsView: filterSelfTask: pkg= net.gsantner.markor, getPackageName= net.oneplus.launcher                                            01-07 09:46:49.402 23784 23784 D RecentsView: applyLoadPlan: id=91025, cmp=ComponentInfo{net.gsantner.markor/net.gsantner.markor.activity.MainActivity}, uid=0, locked=true                                                     
01-07 09:46:50.565  1494  5335 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       01-07 09:46:50.565  1494  5335 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:46:50.569  1494  6166 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       
01-07 09:46:50.569  1494  6166 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:46:50.582  1494  1618 D RestartProcessManager: Update Total Launch Times :net.gsantner.markor          01-07 09:46:50.582  1494  1618 D RestartProcessManager: updateSelf :  net.gsantner.markor, size : 30            01-07 09:46:50.582  1494  1618 D RestartProcessManager: Increase Total Launch Time : net.gsantner.markor, times : 4, index : 29                                         
01-07 09:46:50.582  1494  1618 D RestartProcessManager: Last Running Package : net.gsantner.markor , start time 1736218010582                                           
01-07 09:46:50.664 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=24001, inputTypeString=Normal[MultiLine|CapSentences], enableLearning=true, autoCorrection=true, autoComplete=true, imeOptions=50000006, privateImeOptions=null, actionName=DONE, actionLabel=null, initialSelStart=63, initialSelEnd=63, initialCapsMode=2000, label=null, fieldId=2131296503, fieldName=null, extras=Bundle[mParcelledData.dataSize=844], hintText=null, hintLocales=[]}}, false)                                               
01-07 09:46:51.864 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=0, inputTypeString=NULL, enableLearning=false, autoCorrection=false, autoComplete=false, imeOptions=0, privateImeOptions=null, actionName=UNSPECIFIED, actionLabel=null, initialSelStart=-1, initialSelEnd=-1, initialCapsMode=0, label=null, fieldId=-1, fieldName=null, extras=null, hintText=null, hintLocales=[]}}, false)    
01-07 09:46:52.793  1494  6166 I ActivityManager: START u0 {act=android.media.action.IMAGE_CAPTURE flg=0x3 cmp=android/com.android.internal.app.ResolverActivity clip={text/uri-list U:content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg} (has extras)} from uid 10191 pid 8876                          
01-07 09:46:52.810  1494  1618 D RestartProcessManager: increase duration : 2228 for net.gsantner.markor        
01-07 09:46:53.668  1494  6166 I ActivityManager: START u0 {act=android.media.action.IMAGE_CAPTURE flg=0x3000003 cmp=com.oneplus.camera/.OPCameraServiceActivity clip={text/uri-list U:content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg} (has extras)} from uid 10191 pid -1                            01-07 09:46:53.740 10761 10761 V OPCameraServiceActivity: checkStartMode() - Start mode: SERVICE_PHOTO, Media extras: com.oneplus.camera.MediaResultInfo@a744eda - [ extraDurationLimit: 0, extraOutput: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, extraSizeLimit: 0, extraVideoQuality: 0 ], Launch source: NORMAL                                     
01-07 09:47:04.904 10761 12868 E RequestedPhotoSaveTask: onGenerateFilePath() - Fail to create /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures                                               
01-07 09:47:04.904 10761 12868 V RequestedPhotoSaveTask: saveMediaToFile() - File path : /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                             
01-07 09:47:04.919 10761 12868 E ImageUtils: decodeOrientation() - Fail to access file /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                               
01-07 09:47:04.919 10761 12868 E ImageUtils: java.io.FileNotFoundException: /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg (No such file or directory)              
01-07 09:47:04.919 10761 12868 V RequestedPhotoSaveTask: insertToMediaStore() - Content URI : content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                                          

01-07 09:47:04.919 10761 12868 V RequestedPhotoSaveTask: onInsertToGalleryDatabase() - File path: /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, content Uri: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, content values: oneplus_flags=1                                                    

01-07 09:47:04.919 10761 12868 E RequestedPhotoSaveTask: onInsertToGalleryDatabase() - Fail to get media ID from URI : content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                 

01-07 09:47:06.155 10761 10761 V OPCameraServiceActivity: setMediaResult() - OK, Uri: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                                                  

01-07 09:47:06.191  1494  3336 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       

01-07 09:47:06.191  1494  3336 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:47:06.193  1494  1618 D RestartProcessManager: Update Total Launch Times :net.gsantner.markor         
01-07 09:47:06.193  1494  1618 D RestartProcessManager: updateSelf :  net.gsantner.markor, size : 30            

01-07 09:47:06.193  1494  1618 D RestartProcessManager: Increase Total Launch Time : net.gsantner.markor, times : 5, index : 29                                         
01-07 09:47:06.193  1494  1618 D RestartProcessManager: Last Running Package : net.gsantner.markor , start time 1736218026193                                           

01-07 09:47:06.300 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=0, inputTypeString=NULL, enableLearning=false, autoCorrection=false, autoComplete=false, imeOptions=0, privateImeOptions=null, actionName=UNSPECIFIED, actionLabel=null, initialSelStart=-1, initialSelEnd=-1, initialCapsMode=0, label=null, fieldId=-1, fieldName=null, extras=null, hintText=null, hintLocales=[]}}, false)    

01-07 09:47:09.473 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=24001, inputTypeString=Normal[MultiLine|CapSentences], enableLearning=true, autoCorrection=true, autoComplete=true, imeOptions=50000006, privateImeOptions=null, actionName=DONE, actionLabel=null, initialSelStart=63, initialSelEnd=63, initialCapsMode=2000, label=null, fieldId=2131296503, fieldName=null, extras=Bundle[mParcelledData.dataSize=844], hintText=null, hintLocales=[]}}, false)                                               

01-07 09:47:10.115  1494  1618 D RestartProcessManager: increase duration : 3922 for net.gsantner.markor        

01-07 09:47:10.135 23784 23784 W RecentsView: filterSelfTask: pkg= net.gsantner.markor, getPackageName= net.oneplus.launcher                                            

01-07 09:47:10.136 23784 23784 D RecentsView: applyLoadPlan: id=91025, cmp=ComponentInfo{net.gsantner.markor/net.gsantner.markor.activity.MainActivity}, uid=0, locked=true                                                     

01-07 09:47:10.522   840  1431 W SurfaceFlinger: Attempting to set client state on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0   

01-07 09:47:10.522   840  1431 W SurfaceFlinger: Attempting to destroy on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0            

01-07 09:47:10.524   840  1431 W SurfaceFlinger: Attempting to set client state on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0   

01-07 09:47:10.524   840  1431 W SurfaceFlinger: Attempting to destroy on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0

0 replies

harshad1 · 2025-01-07T06:55:34Z

harshad1
Jan 7, 2025
Collaborator

What did you observe on device when these logs were generated? Did the process just fail silently? Was there a crash?

0 replies

shamefulCake1 · 2025-01-08T03:59:51Z

shamefulCake1
Jan 8, 2025
Author

There is no crash, and the issue is not happening 100% of the time.

It works like this:

I tap "attach image" in the lower-right corner.
The popup with source selection appears (browse filesystem, camera picture, gallery picture, edit picture), with two empty fields "description" and "url"
I tap on either "camera picture" or "gallery picture"
I navigate either the camera or the gallery, and eventually select the picture
(If attachment fails) I am back to the image selection popup, and both Url and Description are still empty.
I can retry the same action until it succeeds, in which case I am not getting the attachment popup with fields filled-in, I am rather getting a normal attachment line in the file.

There is no crash or error report.

Unlike the OP-post, the remaining issue is not a blocker. It's merely annoying.

And it does not seem to be related to the orientation or back-front camera switching, because a gallery has nothing like an orientation.

0 replies

harshad1 · 2025-01-18T04:40:40Z

harshad1
Jan 18, 2025
Collaborator

Can you check if the image was actually copied to your notebook. By default to a .res or _res directory next to the file you tried to attach to

0 replies

shamefulCake1 · 2025-01-18T05:47:55Z

shamefulCake1
Jan 18, 2025
Author

It's not copied and the directory is not created.

0 replies

shamefulCake1 · 2025-03-13T15:44:37Z

shamefulCake1
Mar 13, 2025
Author

2025-03-13 23:43:21.149 28827-20759 RequestedPhotoSaveTask  pid-28827                            E  onGenerateFilePath() - Fail to create /external_files/storage/emulated/0/Android/data/net.gsantner.markor_test/files/Pictures
2025-03-13 23:43:21.243 28827-20759 ImageUtils              pid-28827                            E  decodeOrientation() - Fail to access file /external_files/storage/emulated/0/Android/data/net.gsantner.markor_test/files/Pictures/IMG_20250313-234315.jpg
                                                                                                    java.io.FileNotFoundException: /external_files/storage/emulated/0/Android/data/net.gsantner.markor_test/files/Pictures/IMG_20250313-234315.jpg (No such file or directory)
                                                                                                    	at java.io.FileInputStream.open0(Native Method)
                                                                                                    	at java.io.FileInputStream.open(FileInputStream.java:231)
                                                                                                    	at java.io.FileInputStream.<init>(FileInputStream.java:165)
                                                                                                    	at java.io.FileInputStream.<init>(FileInputStream.java:112)
                                                                                                    	at com.oneplus.media.ImageUtils.decodeOrientation(ImageUtils.java:1665)
                                                                                                    	at com.oneplus.camera.io.PhotoSaveTask.onPrepareMediaStoreValues(PhotoSaveTask.java:533)
                                                                                                    	at com.oneplus.camera.io.MediaSaveTask.insertToMediaStore(MediaSaveTask.java:256)
                                                                                                    	at com.oneplus.camera.io.PhotoSaveTask.insertToMediaStore(PhotoSaveTask.java:366)
                                                                                                    	at com.oneplus.camera.io.FileManagerImpl$FileManageerThread$1.handleMessage(FileManagerImpl.java:515)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loop(Looper.java:193)
                                                                                                    	at android.os.HandlerThread.run(HandlerThread.java:65)

The file is actually there when I run ls:

adb shell 'ls /storage/emulated/0/Android/data/net.gsantner.markor_test/files/Pictures'
IMG_20250313-233402.jpg
IMG_20250313-233418.jpg
IMG_20250313-233508.jpg
IMG_20250313-233523.jpg
IMG_20250313-233938.jpg
IMG_20250313-234037.jpg
IMG_20250313-234315.jpg

0 replies

shamefulCake1 · 2025-03-14T02:01:11Z

shamefulCake1
Mar 14, 2025
Author

Attachment from gallery also fails.

0 replies

shamefulCake1 · 2025-03-14T03:04:20Z

shamefulCake1
Mar 14, 2025
Author

So, it's impossible to bisect this stuff, because some idiots on jitpack are removing older jar files.

0 replies

shamefulCake1 · 2025-03-14T03:36:04Z

shamefulCake1
Mar 14, 2025
Author

The diff between a20ea28~1 a20ea28 is fucking 2334 lines. This is criminally insane. How do you expect anyone to debug this pile of junk which deals with at least 15 different issues at a time?

0 replies

harshad1 · 2025-03-14T04:37:43Z

harshad1
Mar 14, 2025
Collaborator

If you think this is bad, I invite you to look at the internals of Android's Textview :)

I am continuing to look into this, FYI.

0 replies

shamefulCake1 · 2025-03-14T12:33:50Z

shamefulCake1
Mar 14, 2025
Author

I compiled 696677169136e9648ddadc0eea4cf3f2abdd87e0 with the following patch:

diff --git a/app/build.gradle b/app/build.gradle
index da493ef3..d4385513 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -137,11 +137,11 @@ dependencies {
 
 
     // UI libs
-    implementation 'com.pixplicity.generate:library:1.1.8'
+    //implementation 'com.pixplicity.generate:library:1.1.8'
     implementation 'com.github.AppIntro:AppIntro:6.2.0'
-    implementation 'com.kailashdabhi:om-recorder:1.1.5'
+    //implementation 'com.kailashdabhi:om-recorder:1.1.5'
     implementation 'com.github.mertakdut:EpubParser:1.0.95'
-    implementation project(':app:thirdparty-lib-src:QuadFlask-colorpicker')
+    //implementation project(':app:thirdparty-lib-src:QuadFlask-colorpicker')
 
     // Tool libraries
     //noinspection AnnotationProcessorOnCompilePath
diff --git a/app/src/main/java/net/gsantner/markor/activity/MainActivity.java b/app/src/main/java/net/gsantner/markor/activity/MainActivity.java
index b5f5b949..13550004 100644
--- a/app/src/main/java/net/gsantner/markor/activity/MainActivity.java
+++ b/app/src/main/java/net/gsantner/markor/activity/MainActivity.java
@@ -182,11 +182,12 @@ public class MainActivity extends MarkorBaseActivity implements GsFileBrowserFra
 
     private void optShowRate() {
         try {
-            new com.pixplicity.generate.Rate.Builder(this)
-                    .setTriggerCount(4)
-                    .setMinimumInstallTime((int) TimeUnit.MINUTES.toMillis(30))
-                    .setFeedbackAction(() -> _cu.showGooglePlayEntryForThisApp(MainActivity.this))
-                    .build().count().showRequest();
+//            new com.pixplicity.generate.Rate.Builder(this)
+//                    .setTriggerCount(4)
+//                    .setMinimumInstallTime((int) TimeUnit.MINUTES.toMillis(30))
+//                    .setFeedbackAction(() -> _cu.showGooglePlayEntryForThisApp(MainActivity.this))
+//                    .build().count().showRequest();
+            Log.e("lwf", "disabled");
         } catch (Exception ignored) {
         }
     }
diff --git a/app/src/main/java/net/gsantner/markor/format/ActionButtonBase.java b/app/src/main/java/net/gsantner/markor/format/ActionButtonBase.java
index eefc9aa2..fb327754 100644
--- a/app/src/main/java/net/gsantner/markor/format/ActionButtonBase.java
+++ b/app/src/main/java/net/gsantner/markor/format/ActionButtonBase.java
@@ -23,6 +23,7 @@ import android.webkit.WebView;
 import android.widget.EditText;
 import android.widget.HorizontalScrollView;
 import android.widget.ImageView;
+import android.widget.Toast;
 
 import androidx.annotation.DrawableRes;
 import androidx.annotation.NonNull;
@@ -30,10 +31,10 @@ import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.appcompat.widget.TooltipCompat;
 
-import com.flask.colorpicker.ColorPickerView;
-import com.flask.colorpicker.Utils;
-import com.flask.colorpicker.builder.ColorPickerClickListener;
-import com.flask.colorpicker.builder.ColorPickerDialogBuilder;
+//import com.flask.colorpicker.ColorPickerView;
+//import com.flask.colorpicker.Utils;
+//import com.flask.colorpicker.builder.ColorPickerClickListener;
+//import com.flask.colorpicker.builder.ColorPickerDialogBuilder;
 
 import net.gsantner.markor.ApplicationObject;
 import net.gsantner.markor.R;
@@ -835,43 +836,8 @@ public abstract class ActionButtonBase {
     }
 
     public void showColorPickerDialog() {
-        MarkorDialogFactory.showColorSelectionModeDialog(getActivity(), new GsCallback.a1<Integer>() {
-            @Override
-            public void callback(Integer colorInsertType) {
-                ColorPickerDialogBuilder
-                        .with(_hlEditor.getContext())
-                        .setTitle(R.string.color)
-                        .wheelType(ColorPickerView.WHEEL_TYPE.FLOWER)
-                        .density(12)
-                        .setPositiveButton(android.R.string.ok, new ColorPickerClickListener() {
-                            @Override
-                            public void onClick(DialogInterface dialog, int selectedColor, Integer[] allColors) {
-                                String hex = Utils.getHexString(selectedColor, false).toLowerCase();
-                                int pos = _hlEditor.getSelectionStart();
-                                switch (colorInsertType) {
-                                    case R.string.hexcode: {
-                                        _hlEditor.getText().insert(pos, hex);
-                                        break;
-                                    }
-                                    case R.string.foreground: {
-                                        _hlEditor.getText().insert(pos, "<span style='color:" + hex + ";'></span>");
-                                        _hlEditor.setSelection(_hlEditor.getSelectionStart() - 7);
-                                        break;
-                                    }
-                                    case R.string.background: {
-                                        _hlEditor.getText().insert(pos, "<span style='background-color:" + hex + ";'></span>");
-                                        _hlEditor.setSelection(_hlEditor.getSelectionStart() - 7);
-                                        break;
-                                    }
-                                }
-
-                            }
-                        })
-                        .setNegativeButton(R.string.cancel, null)
-                        .build()
-                        .show();
-            }
-        });
+        Toast.makeText(this.m_activity, "removed this feature", Toast.LENGTH_SHORT)
+                .show();
     }
 
     public void runJumpBottomTopAction(ActionItem.DisplayMode displayMode) {
diff --git a/app/src/main/java/net/gsantner/opoc/frontend/GsAudioRecordOmDialog.java b/app/src/main/java/net/gsantner/opoc/frontend/GsAudioRecordOmDialog.java
index cfae05ea..26762e01 100644
--- a/app/src/main/java/net/gsantner/opoc/frontend/GsAudioRecordOmDialog.java
+++ b/app/src/main/java/net/gsantner/opoc/frontend/GsAudioRecordOmDialog.java
@@ -42,12 +42,12 @@ import java.util.Locale;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicReference;
 
-import omrecorder.AudioRecordConfig;
-import omrecorder.OmRecorder;
-import omrecorder.PullTransport;
-import omrecorder.PullableSource;
-import omrecorder.Recorder;
-
+//import omrecorder.AudioRecordConfig;
+//import omrecorder.OmRecorder;
+//import omrecorder.PullTransport;
+//import omrecorder.PullableSource;
+//import omrecorder.Recorder;
+//
 
 //
 // Callback: Called when successfully recorded
@@ -75,7 +75,7 @@ public class GsAudioRecordOmDialog {
 
         final AtomicBoolean isRecording = new AtomicBoolean();
         final AtomicBoolean isRecordSavedOnce = new AtomicBoolean();
-        final AtomicReference<Recorder> recorder = new AtomicReference<>();
+        //final AtomicReference<Recorder> recorder = new AtomicReference<>();
         final AtomicReference<MediaPlayer> mediaPlayer = new AtomicReference<>();
         final AtomicReference<AlertDialog> dialog = new AtomicReference<>();
         final AtomicReference<Long> startTime = new AtomicReference<>();
@@ -87,13 +87,14 @@ public class GsAudioRecordOmDialog {
         // Record management callbacks
         final GsCallback.a2<Boolean, Boolean> recorderManager = (cbArgRestart, cbArgStop) -> {
             if (cbArgRestart) {
-                final PullableSource SRC_MICROPHONE = new PullableSource.Default(new AudioRecordConfig.Default(MediaRecorder.AudioSource.MIC, AudioFormat.ENCODING_PCM_16BIT, AudioFormat.CHANNEL_IN_STEREO, 44100));
-                recorder.set(OmRecorder.wav(new PullTransport.Default(SRC_MICROPHONE), TMP_FILE_RECORDING));
-                recorder.get().startRecording();
+//                final PullableSource SRC_MICROPHONE = new PullableSource.Default(new AudioRecordConfig.Default(MediaRecorder.AudioSource.MIC, AudioFormat.ENCODING_PCM_16BIT, AudioFormat.CHANNEL_IN_STEREO, 44100));
+//                recorder.set(OmRecorder.wav(new PullTransport.Default(SRC_MICROPHONE), TMP_FILE_RECORDING));
+//                recorder.get().startRecording();
                 startTime.set(System.currentTimeMillis());
             } else if (cbArgStop) {
                 try {
-                    recorder.get().stopRecording();
+                    if(true) throw new RuntimeException("lwf:disabled");
+                    //recorder.get().stopRecording();
                     isRecordSavedOnce.set(true);
 
                     int[] diff = GsFileUtils.getTimeDiffHMS(System.currentTimeMillis(), startTime.get());
@@ -173,7 +174,8 @@ public class GsAudioRecordOmDialog {
             final boolean isSavePressed = (dialogButtonCase == DialogInterface.BUTTON_POSITIVE);
             if (isRecordSavedOnce.get()) {
                 try {
-                    recorder.get().stopRecording();
+                    throw new RuntimeException("disabled");
+                    //recorder.get().stopRecording();
                 } catch (Exception ignored) {
                 }
                 if (!isSavePressed) {
diff --git a/app/thirdparty/java/other/com/flask/colorpicker/ColorPickerPreference.java b/app/thirdparty/java/other/com/flask/colorpicker/ColorPickerPreference.java
index 27d3b720..32844b82 100644
--- a/app/thirdparty/java/other/com/flask/colorpicker/ColorPickerPreference.java
+++ b/app/thirdparty/java/other/com/flask/colorpicker/ColorPickerPreference.java
@@ -1,27 +1,29 @@
 package other.com.flask.colorpicker;
 
 import android.content.Context;
-import android.content.DialogInterface;
-import android.content.res.Resources;
+//import android.content.DialogInterface;
+//import android.content.res.Resources;
 import android.content.res.TypedArray;
 import android.graphics.Color;
-import android.graphics.drawable.Drawable;
-import android.graphics.drawable.GradientDrawable;
+//import android.graphics.drawable.Drawable;
+//import android.graphics.drawable.GradientDrawable;
 import android.text.TextUtils;
 import android.util.AttributeSet;
-import android.util.TypedValue;
+import android.util.Log;
+//import android.util.TypedValue;
 import android.widget.ImageView;
+//import android.widget.Toast;
 
 import androidx.annotation.NonNull;
 import androidx.preference.Preference;
 import androidx.preference.PreferenceViewHolder;
 
-import com.flask.colorpicker.ColorPickerView;
-import com.flask.colorpicker.Utils;
-import com.flask.colorpicker.builder.ColorPickerClickListener;
-import com.flask.colorpicker.builder.ColorPickerDialogBuilder;
+//import com.flask.colorpicker.ColorPickerView;
+//import com.flask.colorpicker.Utils;
+//import com.flask.colorpicker.builder.ColorPickerClickListener;
+//import com.flask.colorpicker.builder.ColorPickerDialogBuilder;
 
-import net.gsantner.markor.R;
+//import net.gsantner.markor.R;
 
 public class ColorPickerPreference extends Preference {
 
@@ -30,7 +32,7 @@ public class ColorPickerPreference extends Preference {
 
     protected int selectedColor = 0;
 
-    protected ColorPickerView.WHEEL_TYPE wheelType;
+//    protected ColorPickerView.WHEEL_TYPE wheelType;
     protected int density;
 
     private String pickerTitle;
@@ -56,74 +58,48 @@ public class ColorPickerPreference extends Preference {
 
 
     private void initWith(Context context, AttributeSet attrs) {
-        final TypedArray typedArray = context.obtainStyledAttributes(attrs, R.styleable.ColorPickerPreference);
-
-        try {
-            alphaSlider = typedArray.getBoolean(R.styleable.ColorPickerPreference_alphaSlider, true);
-            lightSlider = typedArray.getBoolean(R.styleable.ColorPickerPreference_lightnessSlider, true);
-
-            density = typedArray.getInt(R.styleable.ColorPickerPreference_density, 10);
-            wheelType = ColorPickerView.WHEEL_TYPE.indexOf(typedArray.getInt(R.styleable.ColorPickerPreference_wheelType, 0));
-
-            selectedColor = typedArray.getInt(R.styleable.ColorPickerPreference_initialColor, 0xffffffff);
-
-            pickerTitle = typedArray.getString(R.styleable.ColorPickerPreference_pickerTitle);
-            if (pickerTitle == null)
-                pickerTitle = "Choose color";
-
-            pickerButtonCancel = typedArray.getString(R.styleable.ColorPickerPreference_pickerButtonCancel);
-            if (pickerButtonCancel == null)
-                pickerButtonCancel = context.getString(R.string.cancel);
-
-            pickerButtonOk = typedArray.getString(R.styleable.ColorPickerPreference_pickerButtonOk);
-            if (pickerButtonOk == null)
-                pickerButtonOk = context.getString(android.R.string.ok);
-
-        } finally {
-            typedArray.recycle();
-        }
-
-        setWidgetLayoutResource(R.layout.color_widget);
+    Log.e("lwf", "do not init this at all");
     }
 
 
     @Override
     public void onBindViewHolder(@NonNull PreferenceViewHolder view) {
         super.onBindViewHolder(view);
-
-        Resources res = getContext().getResources();
-        GradientDrawable colorChoiceDrawable = null;
-
-        colorIndicator = (ImageView) view.findViewById(R.id.color_indicator);
-
-        Drawable currentDrawable = colorIndicator.getDrawable();
-        if (currentDrawable != null && currentDrawable instanceof GradientDrawable)
-            colorChoiceDrawable = (GradientDrawable) currentDrawable;
-
-        if (colorChoiceDrawable == null) {
-            colorChoiceDrawable = new GradientDrawable();
-            colorChoiceDrawable.setShape(GradientDrawable.OVAL);
-        }
-
-        int tmpColor = isEnabled()
-                ? selectedColor
-                : darken(selectedColor, .5f);
-
-        colorChoiceDrawable.setColor(tmpColor);
-        colorChoiceDrawable.setStroke((int) TypedValue.applyDimension(
-                TypedValue.COMPLEX_UNIT_DIP,
-                1,
-                res.getDisplayMetrics()
-        ), darken(tmpColor, .8f));
-
-        colorIndicator.setImageDrawable(colorChoiceDrawable);
+return;
+//        Resources res = getContext().getResources();
+//        GradientDrawable colorChoiceDrawable = null;
+//
+//        colorIndicator = (ImageView) view.findViewById(R.id.color_indicator);
+//
+//        Drawable currentDrawable = colorIndicator.getDrawable();
+//        if (currentDrawable != null && currentDrawable instanceof GradientDrawable)
+//            colorChoiceDrawable = (GradientDrawable) currentDrawable;
+//
+//        if (colorChoiceDrawable == null) {
+//            colorChoiceDrawable = new GradientDrawable();
+//            colorChoiceDrawable.setShape(GradientDrawable.OVAL);
+//        }
+//
+//        int tmpColor = isEnabled()
+//                ? selectedColor
+//                : darken(selectedColor, .5f);
+//
+//        colorChoiceDrawable.setColor(tmpColor);
+//        colorChoiceDrawable.setStroke((int) TypedValue.applyDimension(
+//                TypedValue.COMPLEX_UNIT_DIP,
+//                1,
+//                res.getDisplayMetrics()
+//        ), darken(tmpColor, .8f));
+//
+//        colorIndicator.setImageDrawable(colorChoiceDrawable);
     }
 
     @Override
     public CharSequence getSummary() {
         CharSequence text = super.getSummary();
         if (TextUtils.isEmpty(text)) {
-            text = Utils.getHexString(selectedColor, false).toLowerCase();
+            throw new RuntimeException("this should not appear");
+            //text = Utils.getHexString(selectedColor, false).toLowerCase();
         }
         return text;
     }
@@ -149,28 +125,29 @@ public class ColorPickerPreference extends Preference {
 
     @Override
     protected void onClick() {
-        ColorPickerDialogBuilder builder = ColorPickerDialogBuilder
-                .with(getContext())
-                .setTitle(pickerTitle)
-                .initialColor(selectedColor)
-                .wheelType(wheelType)
-                .density(density)
-                .setPositiveButton(pickerButtonOk, new ColorPickerClickListener() {
-                    @Override
-                    public void onClick(DialogInterface dialog, int selectedColorFromPicker, Integer[] allColors) {
-                        setValue(selectedColorFromPicker);
-                    }
-                })
-                .setNegativeButton(pickerButtonCancel, null);
-
-        if (!alphaSlider && !lightSlider) builder.noSliders();
-        else if (!alphaSlider) builder.lightnessSliderOnly();
-        else if (!lightSlider) builder.alphaSliderOnly();
-
-
-        builder
-                .build()
-                .show();
+        Log.e("lwf", "disabled");
+//        ColorPickerDialogBuilder builder = ColorPickerDialogBuilder
+//                .with(getContext())
+//                .setTitle(pickerTitle)
+//                .initialColor(selectedColor)
+//                .wheelType(wheelType)
+//                .density(density)
+//                .setPositiveButton(pickerButtonOk, new ColorPickerClickListener() {
+//                    @Override
+//                    public void onClick(DialogInterface dialog, int selectedColorFromPicker, Integer[] allColors) {
+//                        setValue(selectedColorFromPicker);
+//                    }
+//                })
+//                .setNegativeButton(pickerButtonCancel, null);
+//
+//        if (!alphaSlider && !lightSlider) builder.noSliders();
+//        else if (!alphaSlider) builder.lightnessSliderOnly();
+//        else if (!lightSlider) builder.alphaSliderOnly();
+//
+//
+//        builder
+//                .build()
+//                .show();
     }
 
     public static int darken(int color, float factor) {
diff --git a/settings.gradle b/settings.gradle
index 1359fd6b..5681bdfc 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -1,2 +1,2 @@
-include(':app:thirdparty-lib-src:QuadFlask-colorpicker')
+//include(':app:thirdparty-lib-src:QuadFlask-colorpicker')
 include ':app'

No quality is expected, I just teared off the code which required missing deps, but attaching images works flawlessly with this version.

0 replies

shamefulCake1 · 2025-03-15T05:17:04Z

shamefulCake1
Mar 15, 2025
Author

I have the code in a repo: https://gitlab.com/markor3/markor/-/tree/debug_camera?ref_type=heads

If you need an older commit for comparison. It builds in 2025 and does not seem to fail to take photos.

0 replies

harshad1 · 2025-03-16T19:43:13Z

harshad1
Mar 16, 2025
Collaborator

Could you just create a PR here? Perhaps with 'WIP' or 'Discussion' in the title.

0 replies

shamefulCake1 · 2025-03-17T02:44:09Z

shamefulCake1
Mar 17, 2025
Author

Sorry, I cannot. GitHub requires 2FA for anyone who has uploaded code, and their system is so fubar'ed that I already have two accounts permanently locked up, unable to log in.

0 replies

harshad1 · 2025-03-18T00:44:39Z

harshad1
Mar 18, 2025
Collaborator

What was the change that fixed things for you?

1 reply

shamefulCake1 Mar 18, 2025
Author

I am pretty sure that the last working one is in that branch on gitlab. I can say with certainty that 7199171 was working for sure.

Please, do not spend too much effort on it right now. I appreciate your desire to make Markor good, but I have already invested my time into installing Android studio and bisecting the tree, so I guess, I will have to spend some more time and debug it myself anyway.

However, if you want just skip trying to find the configuration that "worked in the past", it might be worth it to just try and make the current capturing system more reliable. As in, not try to trust the value returned in an "Intent", but rather try to make sure that all capture content (say, camera images) is going into a dedicated directory, and check that directory contents on each activity re-creation, or something like that.

Also, I think it's better to use registerForActivityResult rather than the old method with dispatching over a code recorded into an intent.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New image attachment system often fails #2401

{{title}}

Replies: 18 comments 2 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

New image attachment system often fails #2401

shamefulCake1 Aug 28, 2024

Replies: 18 comments · 2 replies

harshad1 Sep 10, 2024 Collaborator

shamefulCake1 Sep 22, 2024 Author

shamefulCake1 Jan 5, 2025 Author

harshad1 Jan 5, 2025 Collaborator

shamefulCake1 Jan 7, 2025 Author

harshad1 Jan 7, 2025 Collaborator

shamefulCake1 Jan 8, 2025 Author

harshad1 Jan 18, 2025 Collaborator

shamefulCake1 Jan 18, 2025 Author

shamefulCake1 Mar 13, 2025 Author

shamefulCake1 Mar 14, 2025 Author

shamefulCake1 Mar 14, 2025 Author

shamefulCake1 Mar 14, 2025 Author

harshad1 Mar 14, 2025 Collaborator

shamefulCake1 Mar 14, 2025 Author

shamefulCake1 Mar 15, 2025 Author

harshad1 Mar 16, 2025 Collaborator

shamefulCake1 Mar 17, 2025 Author

harshad1 Mar 18, 2025 Collaborator

shamefulCake1 Mar 18, 2025 Author

shamefulCake1
Aug 28, 2024

Replies: 18 comments 2 replies

harshad1
Sep 10, 2024
Collaborator

shamefulCake1 Sep 22, 2024
Author

shamefulCake1
Jan 5, 2025
Author

harshad1
Jan 5, 2025
Collaborator

shamefulCake1
Jan 7, 2025
Author

harshad1
Jan 7, 2025
Collaborator

shamefulCake1
Jan 8, 2025
Author

harshad1
Jan 18, 2025
Collaborator

shamefulCake1
Jan 18, 2025
Author

shamefulCake1
Mar 13, 2025
Author

shamefulCake1
Mar 14, 2025
Author

shamefulCake1
Mar 14, 2025
Author

shamefulCake1
Mar 14, 2025
Author

harshad1
Mar 14, 2025
Collaborator

shamefulCake1
Mar 14, 2025
Author

shamefulCake1
Mar 15, 2025
Author

harshad1
Mar 16, 2025
Collaborator

shamefulCake1
Mar 17, 2025
Author

harshad1
Mar 18, 2025
Collaborator

shamefulCake1 Mar 18, 2025
Author