Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest fixture simtel_path changes DB configuration #823

Closed
GernotMaier opened this issue Mar 5, 2024 · 1 comment · Fixed by #822
Closed

pytest fixture simtel_path changes DB configuration #823

GernotMaier opened this issue Mar 5, 2024 · 1 comment · Fixed by #822
Milestone

Comments

@GernotMaier
Copy link
Contributor

The pytest fixture simtel_path in conftest.py changes the environment parameters and therefore might lead to errors when accessing the DB.

e.g., the line

def corsika_runner(corsika_config_data, io_handler, simtel_path, db_config):

does not provide any DB access.

The line following line is working fine:

def corsika_runner(corsika_config_data, io_handler, db_config, simtel_path):

This should be improved / fixed.

@GernotMaier GernotMaier linked a pull request Mar 5, 2024 that will close this issue
@GernotMaier GernotMaier added this to the Testing milestone Apr 22, 2024
@GernotMaier
Copy link
Contributor Author

This issue was fixed in #822 , but wasn't closed. I am closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant