Fix: notifies validators on AnyCoordoDual contracts. Change: Add n_open_contracts meta field. Add new protected system username.

Author: dtrckd

CONTRIBUTING.md

@@ -90,10 +90,11 @@ The commit name should starts with a name that identify the **type** of modifica
 
 example: `fix/schema: Add color property to roles.`
 
-Here are some common used for so called semantic commit message:
+Here are some common used for so called semantic commit message, which help to write releases notes from the git commit:
 
 - feat: A new feature
 - fix: A bug fix
+- change: something changed (style, configuration, spec)
 - perf: A code change that improves performance
 - refactor: A code change that neither fixes a bug nor adds a feature
 - typo: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)

db/dql.go

@@ -150,6 +150,30 @@ var dqlQueries map[string]string = map[string]string{
             count(uid)
         }
     }`,
+    "count_open_contracts_from_node": `{
+        var(func: eq(Node.nameid, "{{.nameid}}")) {
+            Node.source {
+                Blob.tension {
+                    Tension.contracts @filter(eq(Contract.status, "Open")) {
+                        c as count(uid)
+                    }
+                }
+            }
+        }
+        all() {
+            n_open_contracts: val(c)
+        }
+    }`,
+    "count_open_contracts_from_tension": `{
+        var(func: uid({{id}})) {
+            Tension.contracts @filter(eq(Contract.status, "Open")) {
+                c as count(uid)
+            }
+        }
+        all() {
+            n_open_contracts: val(c)
+        }
+    }`,
     "getOrgaAgg": `{
         var(func: eq(Node.nameid, "{{.nameid}}")) {
             Node.children @filter(eq(Node.role_type, "Guest")) {

graph/notifications.go

@@ -272,6 +272,20 @@ func PushContractNotifications(notif model.ContractNotif) error {
     // Get relevant users for the contract
     users, err := GetUsersToNotify(notif.Tid, true, false, false)
     if err != nil { return err }
+    if notif.Contract.ContractType == model.ContractTypeAnyCoordoDual &&
+    notif.Contract.Event.EventType == model.TensionEventMoved && notif.Contract.Event.New != nil {
+        // The contract is created inside the tension or the node to be moved.
+        // But we also need to notidy users in the target circle.
+        targetid := *notif.Contract.Event.New
+        x, err := db.GetDB().GetSubSubFieldByEq("Node.nameid", targetid, "Node.source", "Blob.tension", "uid")
+        if err != nil { return err }
+        targetTid, _ := x.(string)
+        users2, err := GetUsersToNotify(targetTid, true, false, false)
+        if err != nil { return err }
+        for k,v := range users2 {
+            users[k] = v
+        }
+    }
     // +
     // Add Candidates
     for _, c := range notif.Contract.Candidates {
@@ -447,7 +461,7 @@ func PushNotifNotifications(notif model.NotifNotif, selfNotify bool) error {
 // User helpers
 //
 
-// GetUserToNotify returns a list of user should receive notifications uponf tension updates.
+// GetUserToNotify returns a list of user that should receive notifications upon tension updates.
 // Note: order is important as for priority and emailing policy.
 func GetUsersToNotify(tid string, withAssignees, withSubscribers, withPeers bool) (map[string]model.UserNotifInfo, error) {
     users := make(map[string]model.UserNotifInfo)

graph/resolver.go

@@ -245,6 +245,8 @@ func private(ctx context.Context, obj interface{}, next graphql.Resolver) (inter
     return nil, fmt.Errorf("`%s' field is private", fieldName)
 }
 
+// Use DQL query to fetch the given field=k.
+// If k is not given, "id" is automatically pass to the query template.
 func meta(ctx context.Context, obj interface{}, next graphql.Resolver, f string, k *string) (interface{}, error) {
     data, err:= next(ctx)
     if err != nil { return nil, err }

web/auth/validation.go

@@ -88,27 +88,49 @@ func init() {
         "api": true,
         "auth": true,
         "data": true,
+        "assets": true,
         "static": true,
         "index": true,
         "index.html": true,
-        // front
+        "ghost": true,
+        // front - about
+        "about": true,
+        "help": true,
+        "features": true,
+        "showcases": true,
+        "marketplace": true,
+        "solutions": true,
+        "pricing": true,
+        "trending": true,
+        "topics": true,
+        "manifesto": true,
+        "sitemap": true,
+        "enterprise": true,
+        "collective": true,
+        "developers": true,
+        "terms-of-service": true,
+        // front - app
+        "home": true,
+        "dashboard": true,
         "new": true, // tension, orga, networks
         "explore": true, // orgas, networks, users
         "login": true,
         "logout": true,
         "signup": true,
         "verification": true,
         "password-reset": true,
-        "about": true,
-        "help": true,
-        "features": true,
-        "showcase": true,
         "user": true,
         "users": true,
         "tension": true,
         "tensions": true,
+        "project": true,
+        "projects": true,
+        "calendar": true,
+        "calendars": true,
         "org": true,
+        "orgs": true,
         "network": true,
+        "networks": true,
     }
 }