bug: Snacks image placement off by one in floating window when using Bufferline.nvim

[todmorrison]

Did you check docs and existing issues?

• I have read all the snacks.nvim docs
• I have updated the plugin to the latest version before submitting this issue
• I have searched the existing issues of snacks.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.4

Operating system/version

Arch Linux 6.13.5

Describe the bug

I've actually tracked it down to the following code in Snacks.image.placement.render_fallback, I'm just not certain of the correct/best solution:

384 local pos = vim.api.nvim_win_get_position(win)
385 terminal.set_cursor({ pos[1] + 1 + border.top, pos[2] + border.left })

When Bufferline Nvim is enabled, this results in a blank line above the image and the bottom of the image running into the bottom of the floating window frame (i.e. changing it to "pos[1] + 0 + border.top..." corrects the behavior with Bufferline enabled, but then breaks it otherwise).

Steps To Reproduce

I noticed this when running under WezTerm as "placeholders" is false, but can reproduce under kitty by modifying terminal.lua to make it use "render_fallback". Disabling bufferline.nvim also corrects the output, so it's a required factor.

Expected Behavior

Image output should render inside the floating window box regardless of bufferline.nvim being enabled or not.

[todmorrison]

One workaround / possible solution. Change the code referenced above to:

    local pos = vim.api.nvim_win_get_position(win)
    if vim.o.showtabline == 2 then
      terminal.set_cursor({ pos[1] + border.top, pos[2] + border.left })
    else
      terminal.set_cursor({ pos[1] + 1 + border.top, pos[2] + border.left })
    end

I'm not sure how to handle the case where showtabline = 1. I haven't found an API for "tabline is shown".

[todmorrison]

I think this does it:

diff --git a/lua/snacks/image/placement.lua b/lua/snacks/image/placement.lua
index 05c3269..f07af64 100644
--- a/lua/snacks/image/placement.lua
+++ b/lua/snacks/image/placement.lua
@@ -382,7 +382,11 @@ function M:render_fallback(state)
     self:debug("render_fallback", win)
     local border = setmetatable({ opts = vim.api.nvim_win_get_config(win) }, { __index = Snacks.win }):border_size()
     local pos = vim.api.nvim_win_get_position(win)
-    terminal.set_cursor({ pos[1] + 1 + border.top, pos[2] + border.left })
+    if ( vim.o.showtabline == 2 ) or ( vim.o.showtabline == 1 and vim.fn.tabpagenr('$') > 1 ) then
+      terminal.set_cursor({ pos[1] + border.top, pos[2] + border.left })
+    else
+      terminal.set_cursor({ pos[1] + 1 + border.top, pos[2] + border.left })
+    end
     terminal.request({
       a = "p",
       i = self.img.id,

[todmorrison]

Submitted PR with the above change