Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers/logger, internal/ethapi: exclude valid authorities from access list when calling eth_createAccessList #31336

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

eth/tracers/logger, internal/ethapi: exclude valid authorities from access list when calling eth_createAccessList #31336

wants to merge 4 commits into from
+23 −12

Conversation

sashabeton
Copy link

@sashabeton sashabeton commented Mar 7, 2025 •
edited
Loading

closes #31335

@sashabeton sashabeton changed the title Exclude valid authorities from access list when calling eth_createAccessList core/types, internal/ethapi: exclude valid authorities from access list when calling eth_createAccessList Mar 10, 2025
@sashabeton sashabeton changed the title core/types, internal/ethapi: exclude valid authorities from access list when calling eth_createAccessList eth/tracers/logger, internal/ethapi: exclude valid authorities from access list when calling eth_createAccessList Mar 10, 2025
@sashabeton
Copy link
Author

I suppose authorization list length should be limited to prevent DoS.
However, I'm not sure about the implementation. Should we use msg.GasLimit to calculate max possible authorizations? Should we pass msg.GasLimit - len(authList) * params.CallNewAccountGas to core.ApplyMessage function?

@sashabeton sashabeton mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

@holiman holiman Awaiting requested review from holiman

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: exclude valid authorities from the eth_createAccessList result (EIP-7702)
1 participant
@sashabeton