System information

Any version after 84565dc

Expected behaviour

Tests gracefully shutdown the SimulatedBeacon when Stop is called.

Actual behaviour

If the txpool is terminated during the call to Commit in the tight inner loop here:
https://github.com/ethereum/go-ethereum/blob/master/eth/catalyst/simulated_beacon_api.go#L73

Then, the inner loop will continue to spew out Warn level log messages for several seconds which causes excessive disk i/o.

Steps to reproduce the behaviour

In the OffchainLabs/nitro repo, we have a test that consistently triggered this race because it loops over a function which brings up a simulated geth backend with a simulated beacon, and sends a bunch of transactions, and then shuts the stack down again. With 15 consecutive calls, the race was all-but certain to happen.

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

I have a fix in our fork of go-ethereum that I'll send shortly referencing this issue.