feat: Use defineConfig() and globalIgnores() helpers

[nzakas]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

Update migrate-config to produce configs that use defineConfig() and globalIgnores()

What changes did you make? (Give an overview)

• Updated the return type of createGlobalIgnores function to CallExpression and modified its implementation to use globalIgnores instead of an object expression. (packages/migrate-config/src/migrate-config.js) [1] [2]
• Modified migrateConfigObject to push properties directly instead of mapping them into an object. (packages/migrate-config/src/migrate-config.js)
• Ensured defineConfig is always used by adding it to the imports and creating a defineConfigNode for the configuration array. (packages/migrate-config/src/migrate-config.js) [1] [2] [3] [4]
• Updated all test fixtures to reflect the new configuration format using defineConfig and globalIgnores. This includes changes in both CommonJS (.cjs) and ES Module (.mjs) formats. (packages/migrate-config/tests/fixtures/basic-eslintrc/expected.cjs, packages/migrate-config/tests/fixtures/basic-eslintrc/expected.mjs, packages/migrate-config/tests/fixtures/gitignore-complex/expected.cjs, packages/migrate-config/tests/fixtures/gitignore-complex/expected.mjs, packages/migrate-config/tests/fixtures/gitignore-simple/expected.cjs, packages/migrate-config/tests/fixtures/gitignore-simple/expected.mjs, packages/migrate-config/tests/fixtures/import-duplicate/expected.cjs, packages/migrate-config/tests/fixtures/import-duplicate/expected.mjs, packages/migrate-config/tests/fixtures/no-globals-for-env/expected.cjs, packages/migrate-config/tests/fixtures/no-globals-for-env/expected.mjs, packages/migrate-config/tests/fixtures/overrides-extends/expected.cjs) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27]

Related Issues

fixes #163

Is there anything you'd like reviewers to focus on?

[mdjermanovic]

When the created config doesn't have imports other than eslint/config, migration still prints out that some packages should be added (but doesn't list any):

Migrating .eslintrc.json

Wrote new config to ./eslint.config.mjs

You will need to install the following packages to use the new config:


You can install them using the following command:

npm install  -D

I think the problem is that this code doesn't check whether there are any imports left after filtering out those that don't require additional installation:

rewrite/packages/migrate-config/src/migrate-config-cli.js

Lines 112 to 123 in 473c962

	if (result.imports.size) {
	const addedImports = [...result.imports.entries()]
	.filter(([key, imp]) => imp.added && !key.startsWith("node:"))
	.map(([key]) => key);
	console.log(
	"\nYou will need to install the following packages to use the new config:",
	);
	console.log(`${addedImports.map(imp => `- ${imp}`).join("\n")}\n`);
	console.log("You can install them using the following command:\n");
	console.log(`npm install ${addedImports.join(" ")} -D\n`);
	}

[nzakas]

Fixed

[mdjermanovic]

LGTM, thanks!