-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: normalize patterns to handle "./" prefix in files and ignores #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this. Overall, it looks good.
I think we have a question here: Is it safe to overwrite files
in an existing object or should we be creating a new object? I think we may need to create a new object to be safe, but that would also increase the number of objects we create. And if we do that, perhaps we should only do so when files
has at least one pattern starting with "./"
and reuse every other config as-is?
@eslint/eslint-tsc what do you think?
I think we should create a new object when we need to modify its content. In this case, where at least one of its |
I changed the tag to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Would like @mdjermanovic to approve before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
Addresses issue where patterns starting with "./" were not correctly matched in
files
andignores
.What changes did you make? (Give an overview)
Strip "./" from the start of strings in
files
andignores
so that they match as expected.Related Issues
eslint/eslint#18757
Is there anything you'd like reviewers to focus on?