Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endo: Files absent in package.json "files" should be unusable #426

Closed
kriskowal opened this issue Aug 22, 2020 · 1 comment
Closed

Endo: Files absent in package.json "files" should be unusable #426

kriskowal opened this issue Aug 22, 2020 · 1 comment

Comments

@kriskowal
Copy link
Member

Endo supports importing arbitrary modules from packages that do not supply "exports" in their package.json. To ensure that a package that works in development will also work after publication, Endo should fail if a module is absent from files.

@kriskowal kriskowal mentioned this issue Aug 22, 2020
36 tasks
@kriskowal
Copy link
Member Author

I would like to punt or possibly even just not do this for modules. The qualifiers for modules are already sufficiently limited (they must have a .js, .cjs, .mjs, or .json extension), the behaviors of npm-packlist are sufficiently complex and so deeply entwined with fs (via glob), that a faithful emulation might be more trouble than it’s worth.

The story for respecting files for non-module resources may be a good place to revisit this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant