Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endo: Distinguish "dependency" from "dependency/" module specifiers #425

Closed
kriskowal opened this issue Aug 22, 2020 · 1 comment
Closed
Assignees
Labels
kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024

Comments

@kriskowal
Copy link
Member

A name like "dependency" will first match a built-in, if available, and fall back to an explicit dependency from package.json. A name like "dependency/" will strictly use the dependency from package.json.

@kriskowal kriskowal mentioned this issue Aug 22, 2020
36 tasks
@kriskowal kriskowal added kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024 kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds labels Jan 10, 2024
@kriskowal
Copy link
Member Author

If this comes up again, I would prefer to send an upstream change to prefer the new convention to distinguish node:fs from fs instead of fs from fs/.

Do remind me if a case like this comes up again. I’m closing on the grounds that I prefer not to imagine us emulating this behavior by the only means I can imagine: Adding / suffixes to the canonical module specifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-reviewed-2024-01 Issues that kriskowal is satisfied do not need attention from team bug review as of January, 2024
Projects
None yet
Development

No branches or pull requests

1 participant